Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Side by Side Diff: chrome/browser/render_view_host_delegate.h

Issue 16554: WaitableEvent (Closed)
Patch Set: Addresssing darin's comments (round 2) Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/render_view_host.cc ('k') | chrome/browser/render_view_host_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_RENDER_VIEW_HOST_DELEGATE_H__ 5 #ifndef CHROME_BROWSER_RENDER_VIEW_HOST_DELEGATE_H__
6 #define CHROME_BROWSER_RENDER_VIEW_HOST_DELEGATE_H__ 6 #define CHROME_BROWSER_RENDER_VIEW_HOST_DELEGATE_H__
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/basictypes.h" 11 #include "base/basictypes.h"
12 #include "chrome/browser/autofill_manager.h" 12 #include "chrome/browser/autofill_manager.h"
13 #include "chrome/common/render_messages.h" 13 #include "chrome/common/render_messages.h"
14 #include "webkit/glue/webpreferences.h" 14 #include "webkit/glue/webpreferences.h"
15 15
16 class NavigationEntry; 16 class NavigationEntry;
17 class Profile; 17 class Profile;
18 class RenderProcessHost; 18 class RenderProcessHost;
19 class RenderViewHost; 19 class RenderViewHost;
20 class SkBitmap; 20 class SkBitmap;
21 class WebContents; 21 class WebContents;
22 struct WebDropData; 22 struct WebDropData;
23 enum WindowOpenDisposition; 23 enum WindowOpenDisposition;
24 24
25 namespace base {
26 class WaitableEvent;
27 }
28
25 namespace IPC { 29 namespace IPC {
26 class Message; 30 class Message;
27 } 31 }
28 32
29 namespace gfx { 33 namespace gfx {
30 class Rect; 34 class Rect;
31 } 35 }
32 36
33 namespace net { 37 namespace net {
34 enum LoadState; 38 enum LoadState;
(...skipping 14 matching lines...) Expand all
49 class RenderViewHostDelegate { 53 class RenderViewHostDelegate {
50 public: 54 public:
51 class View { 55 class View {
52 public: 56 public:
53 // The page is trying to open a new page (e.g. a popup window). The 57 // The page is trying to open a new page (e.g. a popup window). The
54 // window should be created associated with the given route, but it should 58 // window should be created associated with the given route, but it should
55 // not be shown yet. That should happen in response to ShowCreatedWindow. 59 // not be shown yet. That should happen in response to ShowCreatedWindow.
56 // 60 //
57 // Note: this is not called "CreateWindow" because that will clash with 61 // Note: this is not called "CreateWindow" because that will clash with
58 // the Windows function which is actually a #define. 62 // the Windows function which is actually a #define.
59 virtual void CreateNewWindow(int route_id, HANDLE modal_dialog_event) = 0; 63 //
64 // NOTE: this takes ownership of @modal_dialog_event
65 virtual void CreateNewWindow(int route_id,
66 base::WaitableEvent* modal_dialog_event) = 0;
60 67
61 // The page is trying to open a new widget (e.g. a select popup). The 68 // The page is trying to open a new widget (e.g. a select popup). The
62 // widget should be created associated with the given route, but it should 69 // widget should be created associated with the given route, but it should
63 // not be shown yet. That should happen in response to ShowCreatedWidget. 70 // not be shown yet. That should happen in response to ShowCreatedWidget.
64 // If |activatable| is false, the widget cannot be activated or get focus. 71 // If |activatable| is false, the widget cannot be activated or get focus.
65 virtual void CreateNewWidget(int route_id, bool activatable) = 0; 72 virtual void CreateNewWidget(int route_id, bool activatable) = 0;
66 73
67 // Show a previously created page with the specified disposition and bounds. 74 // Show a previously created page with the specified disposition and bounds.
68 // The window is identified by the route_id passed to CreateNewWindow. 75 // The window is identified by the route_id passed to CreateNewWindow.
69 // 76 //
(...skipping 310 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 // page. This is used to avoid uninitiated user downloads (aka carpet 387 // page. This is used to avoid uninitiated user downloads (aka carpet
381 // bombing), see DownloadRequestManager for details. 388 // bombing), see DownloadRequestManager for details.
382 virtual void OnEnterOrSpace() { } 389 virtual void OnEnterOrSpace() { }
383 390
384 // If this view can be terminated without any side effects 391 // If this view can be terminated without any side effects
385 virtual bool CanTerminate() const { return true; } 392 virtual bool CanTerminate() const { return true; }
386 }; 393 };
387 394
388 #endif // CHROME_BROWSER_RENDER_VIEW_HOST_DELEGATE_H__ 395 #endif // CHROME_BROWSER_RENDER_VIEW_HOST_DELEGATE_H__
389 396
OLDNEW
« no previous file with comments | « chrome/browser/render_view_host.cc ('k') | chrome/browser/render_view_host_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698