Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1655353002: Issue 25616. Support for extracting methods with function-typed parameters. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -47 lines) Patch
M pkg/analysis_server/lib/src/services/correction/util.dart View 2 chunks +17 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 9 chunks +50 lines, -23 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 16 chunks +57 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-02 22:13:18 UTC) #1
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-02 22:27:42 UTC) #2
scheglov
4 years, 10 months ago (2016-02-02 22:32:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b0c06a5827f3b9773cfa1c6acd97226f6d5e256f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698