mojo/public/cpp/bindings/tests/pickled_struct_chromium.h - Issue 1655333002: Add message sizing to basic IPC traits and struct macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/pickled_struct_chromium.h

Issue 1655333002: Add message sizing to basic IPC traits and struct macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@with-pickles

Patch Set: include ArrayHeader in size (oops!) and ensure the buffer doesn't relocate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/pickled_struct_blink.cc ('k') | mojo/public/cpp/bindings/tests/pickled_struct_chromium.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/tests/pickled_struct_chromium.h

diff --git a/mojo/public/cpp/bindings/tests/pickled_struct_chromium.h b/mojo/public/cpp/bindings/tests/pickled_struct_chromium.h

index b84f7b3b43178cad6698acb8bdfc34a57bc39acd..ec34572da12acd37806407179de6720d7bf2c333 100644

--- a/mojo/public/cpp/bindings/tests/pickled_struct_chromium.h

+++ b/mojo/public/cpp/bindings/tests/pickled_struct_chromium.h

@@ -15,6 +15,7 @@

namespace base {

class Pickle;

class PickleIterator;

+class PickleSizer;

}

namespace mojo {

@@ -55,7 +56,7 @@ template <>

struct ParamTraits<mojo::test::PickledStructChromium> {

using param_type = mojo::test::PickledStructChromium;

- static size_t GetSize(const param_type& p) { return 8; }

+ static void GetSize(base::PickleSizer* sizer, const param_type& p);

static void Write(base::Pickle* m, const param_type& p);

static bool Read(const base::Pickle* m,

base::PickleIterator* iter,