linux: implement WebPluginDelegateProxy::BackgroundChanged

linux: implement WebPluginDelegateProxy::BackgroundChanged

That makes windowless transparent flash much better.

BUG=19157
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23461

[agl, 2009-08-14 05:17:23]

LGTM with style comments only.

http://codereview.chromium.org/165522/diff/1/2
File chrome/renderer/webplugin_delegate_proxy.cc (right):

http://codereview.chromium.org/165522/diff/1/2#newcode629
Line 629: cairo_surface_t *page_surface = cairo_get_target(context);
stars on the left

http://codereview.chromium.org/165522/diff/1/2#newcode630
Line 630: DCHECK(cairo_surface_get_type(page_surface) ==
CAIRO_SURFACE_TYPE_IMAGE);
DCHECK_EQ

http://codereview.chromium.org/165522/diff/1/2#newcode631
Line 631: DCHECK(cairo_image_surface_get_format(page_surface) ==
CAIRO_FORMAT_ARGB32);
... and here

http://codereview.chromium.org/165522/diff/1/2#newcode633
Line 633: const unsigned char *page_bytes =
cairo_image_surface_get_data(page_surface);
stars on the left

http://codereview.chromium.org/165522/diff/1/2#newcode652
Line 652: cairo_surface_t * bg_surface =
cairo_get_target(device.beginPlatformPaint());
a neat compromise, but stars on the left :)

http://codereview.chromium.org/165522/diff/1/2#newcode653
Line 653: DCHECK(cairo_surface_get_type(bg_surface) ==
CAIRO_SURFACE_TYPE_IMAGE);
DCHECK_EQ

http://codereview.chromium.org/165522/diff/1/2#newcode654
Line 654: DCHECK(cairo_image_surface_get_format(bg_surface) ==
CAIRO_FORMAT_ARGB32);
DCHECK_EQ

http://codereview.chromium.org/165522/diff/1/2#newcode656
Line 656: const unsigned char *bg_bytes =
cairo_image_surface_get_data(bg_surface);
SOTL

http://codereview.chromium.org/165522/diff/1/2#newcode662
Line 662: DCHECK(width <= cairo_image_surface_get_width(bg_surface));
DCHECK_LE

http://codereview.chromium.org/165522/diff/1/2#newcode663
Line 663: DCHECK(height <= cairo_image_surface_get_height(bg_surface));
DCHECK_LE

http://codereview.chromium.org/165522/diff/1/2#newcode665
Line 665: const int kBPP = 4;  // ARGB32 = 4 bytes per pixel.
static

[Evan Martin, 2009-08-14 17:57:35]

LGTM

http://codereview.chromium.org/165522/diff/1/2
File chrome/renderer/webplugin_delegate_proxy.cc (right):

http://codereview.chromium.org/165522/diff/1/2#newcode643
Line 643: // Following comments from the windows section, apparently the damage
rect
Capital-W Windows, so it's clear it's referring to the OS.

[piman, 2009-08-14 20:33:47]

http://codereview.chromium.org/165522/diff/1/2
File chrome/renderer/webplugin_delegate_proxy.cc (right):

http://codereview.chromium.org/165522/diff/1/2#newcode629
Line 629: cairo_surface_t *page_surface = cairo_get_target(context);
On 2009/08/14 05:17:24, agl wrote:
> stars on the left

Done.

http://codereview.chromium.org/165522/diff/1/2#newcode630
Line 630: DCHECK(cairo_surface_get_type(page_surface) ==
CAIRO_SURFACE_TYPE_IMAGE);
On 2009/08/14 05:17:24, agl wrote:
> DCHECK_EQ

Done.

http://codereview.chromium.org/165522/diff/1/2#newcode631
Line 631: DCHECK(cairo_image_surface_get_format(page_surface) ==
CAIRO_FORMAT_ARGB32);
On 2009/08/14 05:17:24, agl wrote:
> ... and here

Done.

http://codereview.chromium.org/165522/diff/1/2#newcode633
Line 633: const unsigned char *page_bytes =
cairo_image_surface_get_data(page_surface);
On 2009/08/14 05:17:24, agl wrote:
> stars on the left

Done.

http://codereview.chromium.org/165522/diff/1/2#newcode643
Line 643: // Following comments from the windows section, apparently the damage
rect
On 2009/08/14 17:57:35, Evan Martin wrote:
> Capital-W Windows, so it's clear it's referring to the OS.

Done.

http://codereview.chromium.org/165522/diff/1/2#newcode652
Line 652: cairo_surface_t * bg_surface =
cairo_get_target(device.beginPlatformPaint());
On 2009/08/14 05:17:24, agl wrote:
> a neat compromise, but stars on the left :)

Done.

http://codereview.chromium.org/165522/diff/1/2#newcode653
Line 653: DCHECK(cairo_surface_get_type(bg_surface) ==
CAIRO_SURFACE_TYPE_IMAGE);
On 2009/08/14 05:17:24, agl wrote:
> DCHECK_EQ

Done.

http://codereview.chromium.org/165522/diff/1/2#newcode654
Line 654: DCHECK(cairo_image_surface_get_format(bg_surface) ==
CAIRO_FORMAT_ARGB32);
On 2009/08/14 05:17:24, agl wrote:
> DCHECK_EQ

Done.

http://codereview.chromium.org/165522/diff/1/2#newcode656
Line 656: const unsigned char *bg_bytes =
cairo_image_surface_get_data(bg_surface);
On 2009/08/14 05:17:24, agl wrote:
> SOTL

Done.

http://codereview.chromium.org/165522/diff/1/2#newcode662
Line 662: DCHECK(width <= cairo_image_surface_get_width(bg_surface));
On 2009/08/14 05:17:24, agl wrote:
> DCHECK_LE

Done.

http://codereview.chromium.org/165522/diff/1/2#newcode663
Line 663: DCHECK(height <= cairo_image_surface_get_height(bg_surface));
On 2009/08/14 05:17:24, agl wrote:
> DCHECK_LE

Done.

http://codereview.chromium.org/165522/diff/1/2#newcode665
Line 665: const int kBPP = 4;  // ARGB32 = 4 bytes per pixel.
On 2009/08/14 05:17:24, agl wrote:
> static

Done.

[agl, 2009-08-14 21:19:50]

LGTM