Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1655183002: dart2js cps: Remove interceptors in cases where type propagation fails. (Closed)

Created:
4 years, 10 months ago by asgerf
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Remove interceptors in cases where type propagation fails. After calling a non-intercepted method on an object, that object is known to be self-interceptor: x.foo$1() getInterceptor(x).$eq(x, y) ==> x.foo$1() x.$eq(0, y) Type propagation would handle this if TypeMasks could represent a type containing all self-intercepting classes (see issue #25646). BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/35b6203b9de51dd82d0a4780fbe12321c3a259ee

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove unused method #

Total comments: 1

Patch Set 3 : Remove debugging code & rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -34 lines) Patch
M pkg/compiler/lib/src/cps_ir/duplicate_branch.dart View 1 4 chunks +69 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/optimizers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 1 2 1 chunk +19 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 2 4 chunks +17 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/types/abstract_value_domain.dart View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
asgerf
https://codereview.chromium.org/1655183002/diff/1/pkg/compiler/lib/src/cps_ir/duplicate_branch.dart File pkg/compiler/lib/src/cps_ir/duplicate_branch.dart (right): https://codereview.chromium.org/1655183002/diff/1/pkg/compiler/lib/src/cps_ir/duplicate_branch.dart#newcode4 pkg/compiler/lib/src/cps_ir/duplicate_branch.dart:4: library dart2js.cps_ir.duplicate_branch; // FIXME: Rename file. Will rename before ...
4 years, 10 months ago (2016-02-02 15:30:59 UTC) #2
asgerf
4 years, 10 months ago (2016-02-05 09:25:11 UTC) #4
Kevin Millikin (Google)
LGTM. https://codereview.chromium.org/1655183002/diff/20001/pkg/compiler/lib/src/cps_ir/type_propagation.dart File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right): https://codereview.chromium.org/1655183002/diff/20001/pkg/compiler/lib/src/cps_ir/type_propagation.dart#newcode3111 pkg/compiler/lib/src/cps_ir/type_propagation.dart:3111: print('${value.type} && ${node.refineType} = $type'); Leftover debugging code.
4 years, 10 months ago (2016-02-05 10:28:05 UTC) #5
asgerf
4 years, 10 months ago (2016-02-09 16:52:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
35b6203b9de51dd82d0a4780fbe12321c3a259ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698