content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java - Issue 1655153003: Fire an accessible click event when a web node is clicked on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Issue 1655153003: Fire an accessible click event when a web node is clicked on. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fire_clicked_event

Patch Set: Added test for tap Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_android.cc ('k') | content/renderer/accessibility/blink_ax_enum_conversion.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

index 1f1a5f8f989d3d3ccbf2d1e0d8d066c87987edf9..4af941e8cd98dd5155ef5cedae5facf65c59a6aa 100644

--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

@@ -234,8 +234,6 @@ public class BrowserAccessibilityManager {

return true;

case AccessibilityNodeInfo.ACTION_CLICK:

nativeClick(mNativeObj, virtualViewId);

- sendAccessibilityEvent(virtualViewId,

- AccessibilityEvent.TYPE_VIEW_CLICKED);

return true;

case AccessibilityNodeInfo.ACTION_FOCUS:

nativeFocus(mNativeObj, virtualViewId);

@@ -631,6 +629,11 @@ public class BrowserAccessibilityManager {

}

@CalledByNative

+ private void handleClicked(int id) {

+ sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_CLICKED);

+ }

+ @CalledByNative

private void handleTextSelectionChanged(int id) {

sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_TEXT_SELECTION_CHANGED);

}