Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Issue 1655153003: Fire an accessible click event when a web node is clicked on. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fire_clicked_event
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
index 629b9d68e00bc091f53d032ac00d75dcb66882c6..276a13e106c0cfd285ef610cbd86d5ca493befc1 100644
--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
@@ -237,8 +237,6 @@ public class BrowserAccessibilityManager {
return true;
case AccessibilityNodeInfo.ACTION_CLICK:
nativeClick(mNativeObj, virtualViewId);
- sendAccessibilityEvent(virtualViewId,
David Tseng 2016/02/02 18:49:59 Great; looks like we were always sending clicked e
dmazzoni 2016/02/03 19:13:46 Yeah, but only in response to an ACTION_CLICK, whi
- AccessibilityEvent.TYPE_VIEW_CLICKED);
return true;
case AccessibilityNodeInfo.ACTION_FOCUS:
nativeFocus(mNativeObj, virtualViewId);
@@ -634,6 +632,11 @@ public class BrowserAccessibilityManager {
}
@CalledByNative
+ private void handleClicked(int id) {
+ sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_CLICKED);
+ }
+
+ @CalledByNative
private void handleTextSelectionChanged(int id) {
sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_TEXT_SELECTION_CHANGED);
}

Powered by Google App Engine
This is Rietveld 408576698