Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 165513002: Use 'ud2' assembly mnemonic instead of assembling the opcode as data (Closed)

Created:
6 years, 10 months ago by Roland McGrath
Modified:
6 years, 10 months ago
Reviewers:
sehr
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gcc.git@master
Visibility:
Public.

Description

Use 'ud2' assembly mnemonic instead of assembling the opcode as data The new assembler only applies the bundling logic to things it knows are machine instructions, not to data literals (even if they are in sections that also contain machine instructions). For __builtin_trap, the compiler was emitting ".value 0x0b0f" instead of "ud2", so with bad luck it could wind up that this two-byte instruction straddles a bundle boundary. Using the mnemonic instead avoids that problem. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3792 TEST= toolchain trybots R=sehr@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gcc.git;a=commit;h=ea8b744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gcc/config/i386/i386.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Roland McGrath
6 years, 10 months ago (2014-02-14 00:22:40 UTC) #1
sehr
lgtm
6 years, 10 months ago (2014-02-14 17:15:41 UTC) #2
Roland McGrath
6 years, 10 months ago (2014-02-14 17:22:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as rea8b744 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698