Add a new ThreatSource type to indicate SBHit is from client side detection.

Add a new ThreatSource type to indicate SBHit is from client side detection.
This fixes the crashing caused by hitting NOTREACHED() line in SafeBrowsingPingManager::SafeBrowsingHitUrl(...)

BUG=583388
Committed: https://crrev.com/b1b56bd1db49796614e716dfde0a4c1c5afaa95d
Cr-Commit-Position: refs/heads/master@{#373285}

[Jialiu Lin, 2016-02-02 03:00:15]

Description was changed from

==========
Add a new ThreatSource type to indicate SBHit is from client side detection.
This fixes the crashing caused by hitting NOTREACHED() line in ping_manager.cc

BUG=
==========

to

==========
Add a new ThreatSource type to indicate SBHit is from client side detection.
This fixes the crashing caused by hitting NOTREACHED() line in
SafeBrowsingPingManager::SafeBrowsingHitUrl(...) 

BUG=
==========

[Jialiu Lin, 2016-02-02 03:18:34]

jialiul@chromium.org changed reviewers:
+ nparker@chromium.org

[Jialiu Lin, 2016-02-02 03:18:34]

Unfortunately, the release build crashes too (only tested on linux though)

This CL should fix the problem. PTAL.

[Nathan Parker, 2016-02-02 18:56:34]

lgtm

https://codereview.chromium.org/1655113002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/client_side_detection_host.cc (right):

https://codereview.chromium.org/1655113002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/client_side_detection_host.cc:591:
safe_browsing::ThreatSource::CLIENT_SIDE_DETECTION;
Any tests that should set this as well?

https://codereview.chromium.org/1655113002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/ping_manager.cc (right):

https://codereview.chromium.org/1655113002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/ping_manager.cc:195: threat_source = "csd";
Ping awoz and let him know this is coming.

[Nathan Parker, 2016-02-02 18:57:02]

Oh, and you'll need to update histograms.xml, since this'll generate a new
histogram.

[Jialiu Lin, 2016-02-02 21:47:35]

histograms.xml updated.
Thanks, nparker.

https://codereview.chromium.org/1655113002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/client_side_detection_host.cc (right):

https://codereview.chromium.org/1655113002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/client_side_detection_host.cc:591:
safe_browsing::ThreatSource::CLIENT_SIDE_DETECTION;
On 2016/02/02 18:56:33, nparker wrote:
> Any tests that should set this as well?
ah, thanks for catching this. EXPECT_EQs added to
client_side_detection_host_unittest.cc

https://codereview.chromium.org/1655113002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/ping_manager.cc (right):

https://codereview.chromium.org/1655113002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/ping_manager.cc:195: threat_source = "csd";
On 2016/02/02 18:56:33, nparker wrote:
> Ping awoz and let him know this is coming.
yes, already gave awoz heads-up

[Jialiu Lin, 2016-02-02 21:48:24]

jialiul@chromium.org changed reviewers:
+ holte@chromium.org

[Jialiu Lin, 2016-02-02 21:48:25]

Hi holte, 
Could you take a look at the change made to histograms.xml? 

Thanks,

[Jialiu Lin, 2016-02-02 21:51:51]

Description was changed from

==========
Add a new ThreatSource type to indicate SBHit is from client side detection.
This fixes the crashing caused by hitting NOTREACHED() line in
SafeBrowsingPingManager::SafeBrowsingHitUrl(...) 

BUG=
==========

to

==========
Add a new ThreatSource type to indicate SBHit is from client side detection.
This fixes the crashing caused by hitting NOTREACHED() line in
SafeBrowsingPingManager::SafeBrowsingHitUrl(...) 

BUG=583388
==========

[Steven Holte, 2016-02-03 03:45:55]

lgtm

[Jialiu Lin, 2016-02-03 18:13:29]

The CQ bit was checked by jialiul@chromium.org

[Jialiu Lin, 2016-02-03 18:13:29]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/1655113002/#ps20001
(title: "unit_tests and histogram")

[commit-bot: I haz the power, 2016-02-03 18:14:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1655113002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1655113002/20001

[commit-bot: I haz the power, 2016-02-03 18:52:12]

Description was changed from

==========
Add a new ThreatSource type to indicate SBHit is from client side detection.
This fixes the crashing caused by hitting NOTREACHED() line in
SafeBrowsingPingManager::SafeBrowsingHitUrl(...) 

BUG=583388
==========

to

==========
Add a new ThreatSource type to indicate SBHit is from client side detection.
This fixes the crashing caused by hitting NOTREACHED() line in
SafeBrowsingPingManager::SafeBrowsingHitUrl(...) 

BUG=583388
==========

[commit-bot: I haz the power, 2016-02-03 18:52:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-03 18:53:11]

Description was changed from

==========
Add a new ThreatSource type to indicate SBHit is from client side detection.
This fixes the crashing caused by hitting NOTREACHED() line in
SafeBrowsingPingManager::SafeBrowsingHitUrl(...) 

BUG=583388
==========

to

==========
Add a new ThreatSource type to indicate SBHit is from client side detection.
This fixes the crashing caused by hitting NOTREACHED() line in
SafeBrowsingPingManager::SafeBrowsingHitUrl(...)

BUG=583388

Committed: https://crrev.com/b1b56bd1db49796614e716dfde0a4c1c5afaa95d
Cr-Commit-Position: refs/heads/master@{#373285}
==========

[commit-bot: I haz the power, 2016-02-03 18:53:12]

Patchset 2 (id:??) landed as
https://crrev.com/b1b56bd1db49796614e716dfde0a4c1c5afaa95d
Cr-Commit-Position: refs/heads/master@{#373285}