third_party/WebKit/Source/web/FullscreenController.cpp - Issue 1655083002: Enable SurfaceView fullscreen video on Android with WebMediaPlayerImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/FullscreenController.cpp

Issue 1655083002: Enable SurfaceView fullscreen video on Android with WebMediaPlayerImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@avda-sv

Patch Set: cleaned up Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/blink/webmediaplayer_impl.h ('K') | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/public/platform/WebMediaPlayer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/FullscreenController.cpp

diff --git a/third_party/WebKit/Source/web/FullscreenController.cpp b/third_party/WebKit/Source/web/FullscreenController.cpp

index 0f0e556c6fe9e893d32bda887e08dc3c89aac45a..14c1c32f29b587bbc247332788fd3ace89669b10 100644

--- a/third_party/WebKit/Source/web/FullscreenController.cpp

+++ b/third_party/WebKit/Source/web/FullscreenController.cpp

@@ -36,7 +36,6 @@

#include "core/frame/PageScaleConstraintsSet.h"

#include "core/html/HTMLMediaElement.h"

#include "core/html/HTMLVideoElement.h"

-#include "platform/LayoutTestSupport.h"

#include "platform/RuntimeEnabledFeatures.h"

#include "public/platform/WebLayerTreeView.h"

#include "public/web/WebFrameClient.h"

@@ -84,15 +83,8 @@ void FullscreenController::didEnterFullScreen()

if (isHTMLVideoElement(element)) {

HTMLVideoElement* videoElement = toHTMLVideoElement(element);

- if (videoElement->usesOverlayFullscreenVideo()) {

- if (videoElement->webMediaPlayer()

- // FIXME: There is no embedder-side handling in layout test mode.

- && !LayoutTestSupport::isRunningLayoutTest()) {

- videoElement->webMediaPlayer()->enterFullscreen();

- }

- if (m_webViewImpl->layerTreeView())

- m_webViewImpl->layerTreeView()->setHasTransparentBackground(true);

- }

+ if (videoElement->usesOverlayFullscreenVideo() && m_webViewImpl->layerTreeView())

+ m_webViewImpl->layerTreeView()->setHasTransparentBackground(true);

}