chromecast/renderer/media/chromecast_media_renderer_factory.cc - Issue 1655083002: Enable SurfaceView fullscreen video on Android with WebMediaPlayerImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/renderer/media/chromecast_media_renderer_factory.cc

Issue 1655083002: Enable SurfaceView fullscreen video on Android with WebMediaPlayerImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@avda-sv

Patch Set: Add an empty destructor to satisfy chromium-style Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/renderer/media/chromecast_media_renderer_factory.h ('k') | content/browser/media/android/browser_surface_view_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/renderer/media/chromecast_media_renderer_factory.cc

diff --git a/chromecast/renderer/media/chromecast_media_renderer_factory.cc b/chromecast/renderer/media/chromecast_media_renderer_factory.cc

index fe335a6973a8fb6c1869279e7c9ef1c6a320e936..e14df67cd1f33354ca9c6647af79107d964244fe 100644

--- a/chromecast/renderer/media/chromecast_media_renderer_factory.cc

+++ b/chromecast/renderer/media/chromecast_media_renderer_factory.cc

@@ -26,7 +26,8 @@ scoped_ptr<::media::Renderer> ChromecastMediaRendererFactory::CreateRenderer(

const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,

const scoped_refptr<base::TaskRunner>& worker_task_runner,

::media::AudioRendererSink* audio_renderer_sink,

- ::media::VideoRendererSink* video_renderer_sink) {

+ ::media::VideoRendererSink* video_renderer_sink,

+ const ::media::RequestSurfaceCB& request_surface_cb) {

// TODO(erickung): crbug.com/443956. Need to provide right LoadType.

LoadType cma_load_type = kLoadTypeMediaSource;

scoped_ptr<MediaPipelineProxy> cma_media_pipeline(new MediaPipelineProxy(