Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: content/browser/media/android/browser_surface_view_manager.cc

Issue 1655083002: Enable SurfaceView fullscreen video on Android with WebMediaPlayerImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@avda-sv
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/android/browser_surface_view_manager.cc
diff --git a/content/browser/media/android/browser_surface_view_manager.cc b/content/browser/media/android/browser_surface_view_manager.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e6457ad610dcd8685f5856572a03899b4d2b1ffc
--- /dev/null
+++ b/content/browser/media/android/browser_surface_view_manager.cc
@@ -0,0 +1,58 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/media/android/browser_surface_view_manager.h"
+
+#include "content/browser/android/child_process_launcher_android.h"
+#include "content/browser/android/content_view_core_impl.h"
+#include "content/browser/gpu/gpu_surface_tracker.h"
+#include "content/browser/web_contents/web_contents_impl.h"
+#include "content/common/media/surface_view_manager_messages_android.h"
+#include "content/public/browser/render_frame_host.h"
+
+namespace content {
+
+BrowserSurfaceViewManager::BrowserSurfaceViewManager(
+ RenderFrameHost* render_frame_host)
+ : render_frame_host_(render_frame_host) {}
+
+void BrowserSurfaceViewManager::SetVideoSurface(
+ gfx::ScopedJavaSurface surface) {
+ if (surface.IsEmpty()) {
+ GpuSurfaceTracker::Get()->RemoveSurface(surface_view_id_);
+ UnregisterViewSurface(surface_view_id_);
+ } else {
+ // We mainly use the surface tracker to allocate a surface id for us. The
+ // lookup will go through the Android specific path and get the java
+ // surface directly, so there's no need to add a valid native widget here.
+ surface_view_id_ = GpuSurfaceTracker::Get()->AddSurfaceForNativeWidget(
+ gfx::kNullAcceleratedWidget);
+ RegisterViewSurface(surface_view_id_, surface.j_surface().obj());
+ Send(new RendererSurfaceViewManagerMsg_FullscreenSurfaceCreated(
+ render_frame_host_->GetRoutingID(), surface_view_id_));
+ }
+}
+
+void BrowserSurfaceViewManager::DidExitFullscreen(bool release_media_player) {
+ content_video_view_.reset();
+}
+
+void BrowserSurfaceViewManager::OnCreateFullscreenSurface() {
+ DCHECK(!ContentVideoView::GetInstance());
+ ContentViewCore* cvc = ContentViewCore::FromWebContents(
+ WebContents::FromRenderFrameHost(render_frame_host_));
+ content_video_view_.reset(new ContentVideoView(this, cvc));
+ base::android::ScopedJavaLocalRef<jobject> j_content_video_view =
+ content_video_view_->GetJavaObject(base::android::AttachCurrentThread());
+ if (!j_content_video_view.is_null()) {
+ // XXX: plumb through the size change event.
DaleCurtis 2016/02/02 01:01:32 Do you have a vision for what this looks like? Ano
watk 2016/02/02 20:38:14 Yeah, that's what I was thinking, but haven't figu
watk 2016/02/05 03:42:30 This turned out to be pretty simple. I just pass t
+ content_video_view_->OnVideoSizeChanged(1280, 720);
+ }
+}
+
+bool BrowserSurfaceViewManager::Send(IPC::Message* msg) {
+ return render_frame_host_->Send(msg);
+}
+
+} // namespace content

Powered by Google App Engine
This is Rietveld 408576698