Enable SurfaceView fullscreen video on Android with WebMediaPlayerImpl

content/renderer/media/android/renderer_surface_view_manager.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_RENDERER_MEDIA_ANDROID_RENDERER_SURFACE_VIEW_MANAGER_H_
+#define CONTENT_RENDERER_MEDIA_ANDROID_RENDERER_SURFACE_VIEW_MANAGER_H_
+
+#include "base/callback.h"
+#include "content/common/content_export.h"
+#include "content/public/renderer/render_frame_observer.h"
+#include "media/base/surface_manager.h"
+
+namespace content {
+
+class CONTENT_EXPORT RendererSurfaceViewManager

[DaleCurtis, 2016/02/02 01:01:33]

Seems like this might be okay to just put on the Delegate interface. The down
side would be changing from a callback interface to using the observer
interface. However, if you see future callbacks which may need to be delivered
to all delegate instances ... i.e. in the world of surfaceview everywhere, it
might be a more natural fit.

Another thing to think about is: if you go the route you have here the IPC team
might ask that you write this as a Mojo service instead of creating new
messages. Now that they're officially deprecated and all that :) I think if you
decide against extending the delegate interface it might be worth doing as Mojo.

[watk, 2016/02/02 20:38:14]

I like the idea of putting it on the delegate actually. I'll give that a go.

[watk, 2016/02/05 03:42:30]

I tried putting it in the delegate, but decided it wasn't the right fit for now.
We're planning to = move towards WMPI not knowing about surfaces at all, which
would mean something like giving the SurfaceManager to GVD directly, and that
gets harder if it's part of the delegate interface.

Mojo makes sense. I'll look into doing the Mojo conversion and see how long it
might take me.

+    : public media::SurfaceManager,
+      public RenderFrameObserver {
+ public:
+  explicit RendererSurfaceViewManager(RenderFrame* render_frame);
+  ~RendererSurfaceViewManager() override;
+
+  // RenderFrameObserver override.
+  bool OnMessageReceived(const IPC::Message& msg) override;
+
+  void CreateFullscreenSurface(
+      const media::SurfaceCreatedCB& surface_created_cb) override;
+
+ private:
+  void OnFullscreenSurfaceCreated(int32_t surface_id);
+
+  media::SurfaceCreatedCB pending_surface_created_cb_;
+
+  DISALLOW_COPY_AND_ASSIGN(RendererSurfaceViewManager);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_RENDERER_MEDIA_ANDROID_RENDERER_SURFACE_VIEW_MANAGER_H_