Issue 165500: Prevent mouse down events in the bookmark bar and download shelf from moving the browser window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165500: Prevent mouse down events in the bookmark bar and download shelf from moving the browser window (Closed)

Created:
11 years, 4 months ago by Paul Godavari

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews_googlegroups.com, John Grabowski, Paul Godavari, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Prevent mouse down events in the bookmark bar and download shelf from moving the parent window around. BUG=19305 (http://crbug.com/19305) TEST=Make the download shelf and/or bookmark bar visible. Clicking and dragging on either one should not move the window around. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23409

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -6 lines)			Patch
M	chrome/app/nibs/BookmarkBar.xib	View	1 2 3 4	5 chunks	+14 lines, -6 lines	0 comments	Download
A	chrome/browser/cocoa/bookmark_bar_view.h	View	1 2 3	1 chunk	+17 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/bookmark_bar_view.mm	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/bookmark_bar_view_unittest.mm	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/download_shelf_view.mm	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/download_shelf_view_unittest.mm	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2 3 4	3 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

11 years, 4 months ago (2009-08-13 23:24:58 UTC) #2

This line:
     TEST=Covered by unittests
Simply isn't true.  Please expand with text like "click and drag on download
shelf; make sure it doesn't move the window".  The whole point is something for
a tester to try out.

LGTM otherwise.

http://codereview.chromium.org/165500/diff/1009/13
File chrome/browser/cocoa/bookmark_bar_view.h (right):

http://codereview.chromium.org/165500/diff/1009/13#newcode13
Line 13: @interface BookmarkBarView : NSView {
Remove the { and }

http://codereview.chromium.org/165500/diff/1009/10
File chrome/browser/cocoa/bookmark_bar_view.mm (right):

http://codereview.chromium.org/165500/diff/1009/10#newcode9
Line 9: - (BOOL)mouseDownCanMoveWindow {
Add comment explaining why this is needed

http://codereview.chromium.org/165500/diff/1009/12
File chrome/browser/cocoa/bookmark_bar_view_unittest.mm (right):

http://codereview.chromium.org/165500/diff/1009/12#newcode20
Line 20: TEST_F(BookmarkBarViewTest, CanDragWindow) {
Excellent

Expand Messages | Collapse Messages