Run tools/resources/optimize-png-files.sh on chrome/android/java/res

Run tools/resources/optimize-png-files.sh on chrome/android/java/res

Total size saved is about 58k

BUG=none

Committed: https://crrev.com/a803cc31b42cf16e70019a3704230dbc958f68e6
Cr-Commit-Position: refs/heads/master@{#373277}

[Marc Treib, 2016-02-02 12:24:26]

Description was changed from

==========
Run tools/resources/optimize-png-files.sh on chrome/android/java/res

BUG=none
==========

to

==========
Run tools/resources/optimize-png-files.sh on chrome/android/java/res

Total size saved is about 58k

BUG=none
==========

[Marc Treib, 2016-02-02 12:30:56]

treib@chromium.org changed reviewers:
+ newt@chromium.org

[Marc Treib, 2016-02-02 12:30:56]

Fallout from the other CL :)

(Do we have any policies for when it's worth doing this for existing images? It
will decrease the apk size, but will probably increase the size of an
incremental update...)

[newt (away), 2016-02-02 18:54:06]

On 2016/02/02 12:30:56, Marc Treib wrote:
> Fallout from the other CL :)
> 
> (Do we have any policies for when it's worth doing this for existing images?
It
> will decrease the apk size, but will probably increase the size of an
> incremental update...)

lgtm

We don't have a policy. Currently, it just happens periodically. Ideally, we'd
have a presubmit check that ensures that optimize-png-files.sh is run *before*
each file is committed.

[newt (away), 2016-02-02 18:55:32]

Before you land this, be sure that none of the images have corrupt transparency.
There was an issue where optimize-png-files.sh could cause broken transparency
(e.g. black instead of transparent) if it was using an old version of one of the
libraries it depends on.

[Marc Treib, 2016-02-03 09:54:58]

On 2016/02/02 18:55:32, newt wrote:
> Before you land this, be sure that none of the images have corrupt
transparency.
> There was an issue where optimize-png-files.sh could cause broken transparency
> (e.g. black instead of transparent) if it was using an old version of one of
the
> libraries it depends on.

I've manually checked one of the images, and they all look fine in Rietveld. Is
that good enough? I don't want to go through every image manually...

[newt (away), 2016-02-03 16:49:43]

On 2016/02/03 09:54:58, Marc Treib wrote:
> On 2016/02/02 18:55:32, newt wrote:
> > Before you land this, be sure that none of the images have corrupt
> transparency.
> > There was an issue where optimize-png-files.sh could cause broken
transparency
> > (e.g. black instead of transparent) if it was using an old version of one of
> the
> > libraries it depends on.
> 
> I've manually checked one of the images, and they all look fine in Rietveld.
Is
> that good enough? I don't want to go through every image manually...

Oh, I just meant install Chrome and make sure some of the assets look correct
there. No need to check every single one.

Thanks for doing this!

[Marc Treib, 2016-02-03 17:32:52]

On 2016/02/03 16:49:43, newt wrote:
> On 2016/02/03 09:54:58, Marc Treib wrote:
> > On 2016/02/02 18:55:32, newt wrote:
> > > Before you land this, be sure that none of the images have corrupt
> > transparency.
> > > There was an issue where optimize-png-files.sh could cause broken
> transparency
> > > (e.g. black instead of transparent) if it was using an old version of one
of
> > the
> > > libraries it depends on.
> > 
> > I've manually checked one of the images, and they all look fine in Rietveld.
> Is
> > that good enough? I don't want to go through every image manually...
> 
> Oh, I just meant install Chrome and make sure some of the assets look correct
> there. No need to check every single one.
> 
> Thanks for doing this!

Okay, looks good, so I'll land. Thanks!

[Marc Treib, 2016-02-03 17:33:00]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2016-02-03 17:35:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1654993003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1654993003/1

[commit-bot: I haz the power, 2016-02-03 18:24:33]

Description was changed from

==========
Run tools/resources/optimize-png-files.sh on chrome/android/java/res

Total size saved is about 58k

BUG=none
==========

to

==========
Run tools/resources/optimize-png-files.sh on chrome/android/java/res

Total size saved is about 58k

BUG=none
==========

[commit-bot: I haz the power, 2016-02-03 18:24:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-03 18:25:41]

Description was changed from

==========
Run tools/resources/optimize-png-files.sh on chrome/android/java/res

Total size saved is about 58k

BUG=none
==========

to

==========
Run tools/resources/optimize-png-files.sh on chrome/android/java/res

Total size saved is about 58k

BUG=none

Committed: https://crrev.com/a803cc31b42cf16e70019a3704230dbc958f68e6
Cr-Commit-Position: refs/heads/master@{#373277}
==========

[commit-bot: I haz the power, 2016-02-03 18:25:42]

Patchset 1 (id:??) landed as
https://crrev.com/a803cc31b42cf16e70019a3704230dbc958f68e6
Cr-Commit-Position: refs/heads/master@{#373277}