Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1654983002: Don't use 'info.type', always set 'element'. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 3 chunks +6 lines, -11 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 10 months ago (2016-02-01 20:18:25 UTC) #1
scheglov
https://codereview.chromium.org/1654983002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart File pkg/analyzer/lib/src/summary/resynthesize.dart (right): https://codereview.chromium.org/1654983002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart#newcode1519 pkg/analyzer/lib/src/summary/resynthesize.dart:1519: } Or we could use code like this here: ...
4 years, 10 months ago (2016-02-01 20:19:25 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/1654983002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart File pkg/analyzer/lib/src/summary/resynthesize.dart (right): https://codereview.chromium.org/1654983002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart#newcode1519 pkg/analyzer/lib/src/summary/resynthesize.dart:1519: } On 2016/02/01 20:19:25, scheglov wrote: > Or ...
4 years, 10 months ago (2016-02-01 20:33:29 UTC) #3
scheglov
4 years, 10 months ago (2016-02-01 20:41:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
402ff37f1638c4dfc1100588d0ec40349e123486 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698