MB: Build proprietary codecs for WebRTC Chromium GN bots.

MB: Build proprietary codecs for WebRTC Chromium GN bots.

In order to build and test the OpenH264 codec, we need
to pass additional GN variables to our bots.
These are already used by several bots in Chromium, but
mainly by the GPU team.

OpenH264 is not yet built when they're defined, but the
plan is to make it so soon, so we want to ensure we're
building with it since Chromium tests marked as MANUAL_
are going to be added, which only run in these
WebRTC-controlled waterfalls (tests built with GN is
currently only deployed for Linux though).

This is a similar to the regular Buildbot changes in
https://codereview.chromium.org/1658183002/

BUG=576201
Committed: https://crrev.com/4282b2d5c706295eb44c1d98e00ccf882627ea46
Cr-Commit-Position: refs/heads/master@{#373527}

[kjellander_chromium, 2016-02-02 13:30:38]

kjellander@chromium.org changed reviewers:
+ dpranke@chromium.org

[kjellander_chromium, 2016-02-02 13:30:38]

https://codereview.chromium.org/1654953004/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/1654953004/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:137: # WebRTC Chromium bots that build with proprietary
codecs enabled. These
There's a bit of duplication here compared with the existing configs. Should I
create individual mixins for each of them to eliminate duplication at the cost
of added verbosity?

I just want to make sure they're kept in sync.

https://codereview.chromium.org/1654953004/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:311: 'mixins': ['archive_gpu_tests',
'chrome_with_codecs'],
I assume this is how it worked. I don't indent to change anything for the users
of the gpu_tests, but I wanted to avoid duplicating these settings.

If so - nice framework you built here Dirk!

[kjellander_chromium, 2016-02-02 13:56:00]

I realize I lied about the Linux Builder being on GN - it's not. I'll make a CL
that make it use MB now, so it'll make use of the MB config and actually GN.

[Dirk Pranke, 2016-02-02 22:07:49]

lgtm w/ suggested changes.

https://codereview.chromium.org/1654953004/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/1654953004/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:140: 'webrtc_android_gn_debug_bot': ['android', 'gn',
'debug_bot', 'chrome_with_codecs'],
I would name this 'android_gn_debug_bot_chrome_with_codecs' (basically joining
the mixins together w/ '_').

There's nothing specific about webrtc in these defs, so I wouldn't use that in
the name.

Same for the rest.

https://codereview.chromium.org/1654953004/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:311: 'mixins': ['archive_gpu_tests',
'chrome_with_codecs'],
On 2016/02/02 13:30:38, kjellander (chromium) wrote:
> I assume this is how it worked. I don't indent to change anything for the
users
> of the gpu_tests, but I wanted to avoid duplicating these settings.
> 
> If so - nice framework you built here Dirk!

Yup, that's how this works.

[kjellander_chromium, 2016-02-04 12:23:10]

Renamed the configs according to your comment.

https://codereview.chromium.org/1654953004/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/1654953004/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:140: 'webrtc_android_gn_debug_bot': ['android', 'gn',
'debug_bot', 'chrome_with_codecs'],
On 2016/02/02 22:07:48, Dirk Pranke wrote:
> I would name this 'android_gn_debug_bot_chrome_with_codecs' (basically joining
> the mixins together w/ '_').
> 
> There's nothing specific about webrtc in these defs, so I wouldn't use that in
> the name.
> 
> Same for the rest.

Done.

[kjellander_chromium, 2016-02-04 13:03:52]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2016-02-04 13:03:52]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1654953004/#ps20001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-02-04 13:04:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1654953004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1654953004/20001

[commit-bot: I haz the power, 2016-02-04 14:23:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-04 14:24:42]

Description was changed from

==========
MB: Build proprietary codecs for WebRTC Chromium GN bots.

In order to build and test the OpenH264 codec, we need
to pass additional GN variables to our bots.
These are already used by several bots in Chromium, but
mainly by the GPU team.

OpenH264 is not yet built when they're defined, but the
plan is to make it so soon, so we want to ensure we're
building with it since Chromium tests marked as MANUAL_
are going to be added, which only run in these
WebRTC-controlled waterfalls (tests built with GN is
currently only deployed for Linux though).

This is a similar to the regular Buildbot changes in
https://codereview.chromium.org/1658183002/

BUG=576201
==========

to

==========
MB: Build proprietary codecs for WebRTC Chromium GN bots.

In order to build and test the OpenH264 codec, we need
to pass additional GN variables to our bots.
These are already used by several bots in Chromium, but
mainly by the GPU team.

OpenH264 is not yet built when they're defined, but the
plan is to make it so soon, so we want to ensure we're
building with it since Chromium tests marked as MANUAL_
are going to be added, which only run in these
WebRTC-controlled waterfalls (tests built with GN is
currently only deployed for Linux though).

This is a similar to the regular Buildbot changes in
https://codereview.chromium.org/1658183002/

BUG=576201

Committed: https://crrev.com/4282b2d5c706295eb44c1d98e00ccf882627ea46
Cr-Commit-Position: refs/heads/master@{#373527}
==========

[commit-bot: I haz the power, 2016-02-04 14:24:43]

Patchset 2 (id:??) landed as
https://crrev.com/4282b2d5c706295eb44c1d98e00ccf882627ea46
Cr-Commit-Position: refs/heads/master@{#373527}