Issue 165492: Make "Get Themes" button in prefs foreground the browser window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165492: Make "Get Themes" button in prefs foreground the browser window (Closed)

Created:
11 years, 4 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com, John Grabowski, brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

When you clicked Get Themes in Mac prefs, the browser window containing the themes gallery wasn't coming to the front. There was an implicit assumption on Windows that TabContentsViewWin::Focus caused the window containing the TabContents to be foregrounded. This is because on Windows a HWND is focused with a call to SetFocus, which activates the containing top level window. On Mac, TabContentsViewMac::Focus needs to explicitly activate the containing window. Also, changes the Mac preferences code to call the same function as on Windows, for simplicity. Note: the "foreground" parameter to AddTabWithURL means the tab is opened in the foreground, not that the window is activated. http://crbug.com/18157 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23378

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/cocoa/preferences_window_controller.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/tab_contents/tab_contents_view_mac.mm	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LG

Expand Messages | Collapse Messages