Issue 16549002: Add type field to AST expression nodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16549002: Add type field to AST expression nodes (Closed)

Created:
7 years, 6 months ago by rossberg

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Add type field to AST expression nodes More importantly, do a bunch of renamings of incidental existing "types" to avoid actual and potential name clashes (and also to improve consistency). R=svenpanne@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=14978

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+244 lines, -227 lines)			Patch
M	src/ast.h	View	20 chunks	+39 lines, -30 lines	0 comments	Download
M	src/ast.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/factory.h	View	1 chunk	+9 lines, -9 lines	0 comments	Download
M	src/factory.cc	View	9 chunks	+22 lines, -21 lines	0 comments	Download
M	src/jsregexp.h	View	8 chunks	+18 lines, -19 lines	0 comments	Download
M	src/jsregexp.cc	View	30 chunks	+32 lines, -32 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/parser.h	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	src/parser.cc	View	28 chunks	+74 lines, -69 lines	0 comments	Download
M	src/runtime.cc	View	7 chunks	+11 lines, -9 lines	0 comments	Download
M	src/scopeinfo.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/scopes.h	View	4 chunks	+10 lines, -10 lines	0 comments	Download
M	src/scopes.cc	View	6 chunks	+11 lines, -11 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

rossberg

7 years, 6 months ago (2013-06-06 13:28:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14978 (presubmit successful).