Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1654873004: Temporary fix for socket_many_connections_test. (Closed)

Created:
4 years, 10 months ago by turnidge
Modified:
4 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Temporary fix for socket_many_connections_test. I am working on a more general api change that will make this kind of programming error harder to make in the future. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/f8d48510cf6d2b10f8e66cadf0569364a903cf45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M runtime/bin/socket.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
turnidge
4 years, 10 months ago (2016-02-01 23:39:42 UTC) #2
siva
lgtm
4 years, 10 months ago (2016-02-01 23:40:51 UTC) #3
turnidge
4 years, 10 months ago (2016-02-01 23:42:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f8d48510cf6d2b10f8e66cadf0569364a903cf45 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698