Kill --memory-metrics and on-demand Memory.Browser/RenderUsed histograms

Kill --memory-metrics and on-demand Memory.Browser/RenderUsed histograms

--memory-metrics enable the sampling of two histograms: Memory.BrowserUsed
and Memory.RendererUsed. Those are currently reported in telemetry but:
 - nobody seems to care / be aware of those.
 - there are no perf alerts associated to them.
See discussion in crbug.com/581365.
As memory benchmarks are being superseded by the ones based on memory-infra
removing this obsolete code.

BUG=581365, 160979
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

[Primiano Tucci (use gerrit), 2016-02-01 16:49:52]

Description was changed from

==========
Kill --memory-metrics and on-demand Memory.Browser/RenderUsed histograms

--memory-metrics enable the sampling of two histograms: Memory.BrowserUsed
and Memory.RendererUsed. Those are currently reported in telemetry but:
 - nobody seems to care / be aware of those.
 - there are no perf alerts associated to them.
See discussion in crbug.com/581365.
As memory benchmarks are being superseded by the ones based on memory-infra
removing this obsolete code.

BUG=581365
==========

to

==========
Kill --memory-metrics and on-demand Memory.Browser/RenderUsed histograms

--memory-metrics enable the sampling of two histograms: Memory.BrowserUsed
and Memory.RendererUsed. Those are currently reported in telemetry but:
 - nobody seems to care / be aware of those.
 - there are no perf alerts associated to them.
See discussion in crbug.com/581365.
As memory benchmarks are being superseded by the ones based on memory-infra
removing this obsolete code.

BUG=581365
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
==========

[Primiano Tucci (use gerrit), 2016-02-01 17:03:08]

Description was changed from

==========
Kill --memory-metrics and on-demand Memory.Browser/RenderUsed histograms

--memory-metrics enable the sampling of two histograms: Memory.BrowserUsed
and Memory.RendererUsed. Those are currently reported in telemetry but:
 - nobody seems to care / be aware of those.
 - there are no perf alerts associated to them.
See discussion in crbug.com/581365.
As memory benchmarks are being superseded by the ones based on memory-infra
removing this obsolete code.

BUG=581365
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
==========

to

==========
Kill --memory-metrics and on-demand Memory.Browser/RenderUsed histograms

--memory-metrics enable the sampling of two histograms: Memory.BrowserUsed
and Memory.RendererUsed. Those are currently reported in telemetry but:
 - nobody seems to care / be aware of those.
 - there are no perf alerts associated to them.
See discussion in crbug.com/581365.
As memory benchmarks are being superseded by the ones based on memory-infra
removing this obsolete code.

BUG=581365,160979
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
==========

[Primiano Tucci (use gerrit), 2016-02-05 15:31:43]

primiano@chromium.org changed reviewers:
+ jochen@chromium.org, nednguyen@google.com

[Primiano Tucci (use gerrit), 2016-02-05 15:31:43]

As per crbug.com/581365

> #10 jochen@chromium.org: feel free to delete
Feel free to review :)

[nednguyen, 2016-02-05 15:41:45]

lgtm

[jochen (gone - plz use gerrit), 2016-02-17 11:06:39]

lgtm

[Primiano Tucci (use gerrit), 2016-02-17 11:17:39]

Oh completely forgot about this.

On 2016/02/17 11:06:39, jochen (OOO) wrote:
> lgtm

In 3-way merge we trust.

[Primiano Tucci (use gerrit), 2016-02-17 11:17:46]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2016-02-17 11:18:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1654863003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1654863003/40001

[commit-bot: I haz the power, 2016-02-17 11:21:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 11:21:04]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Primiano Tucci (use gerrit), 2016-02-17 13:35:52]

The CQ bit was checked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2016-02-17 13:35:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
nednguyen@google.com, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1654863003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-02-17 13:36:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1654863003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1654863003/60001

[commit-bot: I haz the power, 2016-02-17 14:42:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 14:42:40]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Primiano Tucci (use gerrit), 2016-02-17 16:41:14]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2016-02-17 16:41:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1654863003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1654863003/60001

[commit-bot: I haz the power, 2016-02-17 17:28:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 17:28:25]

Try jobs failed on following builders:
  android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_p...)

[Primiano Tucci (use gerrit), 2016-02-17 19:17:53]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2016-02-17 19:18:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1654863003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1654863003/60001

[Primiano Tucci (use gerrit), 2016-02-17 19:18:29]

Ned any idea about those perf failures?

Traceback (most recent call last):
  File
"/b/build/slave/linux_perf_bisect/build/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py",
line 84, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File
"/b/build/slave/linux_perf_bisect/build/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py",
line 325, in RunStory
    self._current_page, self._current_tab, results)
  File
"/b/build/slave/linux_perf_bisect/build/src/tools/perf/measurements/memory.py",
line 36, in ValidateAndMeasurePage
    self._memory_metric.AddResults(tab, results)
  File
"/b/build/slave/linux_perf_bisect/build/src/tools/perf/metrics/memory.py", line
132, in AddResults
    assert self._histogram_delta, 'Must call Stop() first'
AssertionError: Must call Stop() first

[commit-bot: I haz the power, 2016-02-17 21:15:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 21:15:50]

Try jobs failed on following builders:
  mac_10_10_perf_bisect on tryserver.chromium.perf (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_b...)

[Primiano Tucci (use gerrit), 2016-02-18 17:57:15]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2016-02-18 18:00:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1654863003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1654863003/60001

[commit-bot: I haz the power, 2016-02-18 18:50:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 18:50:44]

Try jobs failed on following builders:
  linux_perf_bisect on tryserver.chromium.perf (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisec...)

[Primiano Tucci (use gerrit), 2017-05-30 09:55:22]

Closing in favor or tfarina's https://chromium-review.googlesource.com/c/517482/