Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1654833004: Removes invalid use of while loop in WebRtcAudioDeviceImpl::RenderData() (Closed)

Created:
4 years, 10 months ago by henrika (OOO until Aug 14)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, hlundin-chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes invalid use of while loop in WebRtcAudioDeviceImpl::RenderData(). Follow-up task on https://codereview.chromium.org/139303016/ BUG=264611 Committed: https://crrev.com/256fa711cb76bdf8807087199088fd65114747db Cr-Commit-Position: refs/heads/master@{#372969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -25 lines) Patch
M content/renderer/media/webrtc_audio_device_impl.cc View 1 chunk +12 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
henrika (OOO until Aug 14)
Verified on Linux using the following test clients: - Peerconnection audio loopback - AppRTC loopback ...
4 years, 10 months ago (2016-02-02 11:49:37 UTC) #3
tommi (sloooow) - chröme
lgtm
4 years, 10 months ago (2016-02-02 17:07:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1654833004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1654833004/1
4 years, 10 months ago (2016-02-02 17:10:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 17:21:16 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 17:22:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/256fa711cb76bdf8807087199088fd65114747db
Cr-Commit-Position: refs/heads/master@{#372969}

Powered by Google App Engine
This is Rietveld 408576698