Better location for setting the size of tab contents. This should

chrome/browser/browser.cc

Index: chrome/browser/browser.cc
diff --git a/chrome/browser/browser.cc b/chrome/browser/browser.cc
index 5fae3c8986f8d0a3798034c6ec68ead5f98effa3..c6c7ce60f122651b4c3f0321379bee227cb52681 100644
--- a/chrome/browser/browser.cc
+++ b/chrome/browser/browser.cc
@@ -1503,17 +1503,6 @@ TabContents* Browser::CreateTabContentsForURL(
   TabContents* contents = new TabContents(profile, instance,
                                           MSG_ROUTING_NONE, NULL);
 
-  // Ensure that the new TabContentsView begins at the same size as the
-  // previous TabContentsView if it existed.  Otherwise, the initial WebKit
-  // layout will be performed based on a width of 0 pixels, causing a
-  // very long, narrow, inaccurate layout.  Because some scripts on pages (as
-  // well as WebKit's anchor link location calculation) are run on the initial
-  // layout and not recalculated later, we need to ensure the first layout is
-  // performed with sane view dimensions even when we're opening a new
-  // background tab.
-  if (TabContents* old_contents = tabstrip_model_.GetSelectedTabContents())
-    contents->view()->SizeContents(old_contents->view()->GetContainerSize());

[Nate Chapin, 2009/08/13 18:56:54]

My impression (and this could be entirely wrong) was that, in this code path, it
was crucial for SizeContents() to be called before
contents->controller().LoadURL().  Is that still the case with this patch? 
Could you make me feel better and confirm that this code path still functions
correctly? :-)

-
   if (!defer_load) {
     // Load the initial URL before adding the new tab contents to the tab strip
     // so that the tab contents has navigation state.
@@ -1831,18 +1820,6 @@ void Browser::AddNewContents(TabContents* source,
                             initial_pos, user_gesture);
     browser->window()->Show();
   } else if (disposition != SUPPRESS_OPEN) {
-    // Ensure that the new TabContentsView begins at the same size as the
-    // previous TabContentsView if it existed.  Otherwise, the initial WebKit
-    // layout will be performed based on a width of 0 pixels, causing a
-    // very long, narrow, inaccurate layout.  Because some scripts on pages (as
-    // well as WebKit's anchor link location calculation) are run on the
-    // initial layout and not recalculated later, we need to ensure the first
-    // layout is performed with sane view dimensions even when we're opening a
-    // new background tab.
-    if (TabContents* old_contents = tabstrip_model_.GetSelectedTabContents()) {
-      new_contents->view()->SizeContents(
-          old_contents->view()->GetContainerSize());
-    }
     tabstrip_model_.AddTabContents(new_contents, -1, false,
                                    PageTransition::LINK,
                                    disposition == NEW_FOREGROUND_TAB);