Better location for setting the size of tab contents. This should

chrome/browser/browser.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser.h"
 
 #include "app/animation.h"
 #include "app/l10n_util.h"
 #include "base/command_line.h"
 #include "base/idle_timer.h"
@@ skipping 1485 matching lines @@
   return TAB_TEAROFF_ACTION | (tab_count() > 1 ? TAB_MOVE_ACTION : 0);
 }
 
 TabContents* Browser::CreateTabContentsForURL(
     const GURL& url, const GURL& referrer, Profile* profile,
     PageTransition::Type transition, bool defer_load,
     SiteInstance* instance) const {
   TabContents* contents = new TabContents(profile, instance,
                                           MSG_ROUTING_NONE, NULL);
 
-  // Ensure that the new TabContentsView begins at the same size as the
-  // previous TabContentsView if it existed.  Otherwise, the initial WebKit
-  // layout will be performed based on a width of 0 pixels, causing a
-  // very long, narrow, inaccurate layout.  Because some scripts on pages (as
-  // well as WebKit's anchor link location calculation) are run on the initial
-  // layout and not recalculated later, we need to ensure the first layout is
-  // performed with sane view dimensions even when we're opening a new
-  // background tab.
-  if (TabContents* old_contents = tabstrip_model_.GetSelectedTabContents())
-    contents->view()->SizeContents(old_contents->view()->GetContainerSize());

[Nate Chapin, 2009/08/13 18:56:54]

My impression (and this could be entirely wrong) was that, in this code path, it
was crucial for SizeContents() to be called before
contents->controller().LoadURL().  Is that still the case with this patch? 
Could you make me feel better and confirm that this code path still functions
correctly? :-)

-
   if (!defer_load) {
     // Load the initial URL before adding the new tab contents to the tab strip
     // so that the tab contents has navigation state.
     contents->controller().LoadURL(url, referrer, transition);
   }
 
   return contents;
 }
 
 bool Browser::CanDuplicateContentsAt(int index) {
@@ skipping 297 matching lines @@
   }
 
   if (disposition == NEW_POPUP) {
     BuildPopupWindow(source, new_contents, initial_pos);
   } else if (disposition == NEW_WINDOW) {
     Browser* browser = Browser::Create(profile_);
     browser->AddNewContents(source, new_contents, NEW_FOREGROUND_TAB,
                             initial_pos, user_gesture);
     browser->window()->Show();
   } else if (disposition != SUPPRESS_OPEN) {
-    // Ensure that the new TabContentsView begins at the same size as the
-    // previous TabContentsView if it existed.  Otherwise, the initial WebKit
-    // layout will be performed based on a width of 0 pixels, causing a
-    // very long, narrow, inaccurate layout.  Because some scripts on pages (as
-    // well as WebKit's anchor link location calculation) are run on the
-    // initial layout and not recalculated later, we need to ensure the first
-    // layout is performed with sane view dimensions even when we're opening a
-    // new background tab.
-    if (TabContents* old_contents = tabstrip_model_.GetSelectedTabContents()) {
-      new_contents->view()->SizeContents(
-          old_contents->view()->GetContainerSize());
-    }
     tabstrip_model_.AddTabContents(new_contents, -1, false,
                                    PageTransition::LINK,
                                    disposition == NEW_FOREGROUND_TAB);
   }
 }
 
 void Browser::ActivateContents(TabContents* contents) {
   tabstrip_model_.SelectTabContentsAt(
       tabstrip_model_.GetIndexOfTabContents(contents), false);
   window_->Activate();
@@ skipping 951 matching lines @@
 ///////////////////////////////////////////////////////////////////////////////
 // BrowserToolbarModel (private):
 
 NavigationController* Browser::BrowserToolbarModel::GetNavigationController() {
   // This |current_tab| can be NULL during the initialization of the
   // toolbar during window creation (i.e. before any tabs have been added
   // to the window).
   TabContents* current_tab = browser_->GetSelectedTabContents();
   return current_tab ? &current_tab->controller() : NULL;
 }