Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1654703002: Revert of MD History: Add basic material design history cards and history items (Closed)

Created:
4 years, 10 months ago by calamity
Modified:
4 years, 10 months ago
Reviewers:
yingran, tsergeant, Dan Beam
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MD History: Add basic material design history cards and history items (patchset #11 id:240001 of https://codereview.chromium.org/1574063003/ ) Reason for revert: Broke the closure compile. Original issue's description: > MD History: Add basic material design history cards and history items > > This is the first of two patches for the start of MD History. This patch > includes elements for individual items and grouped items. A followup patch will > hook these elements into the page. > > BUG=425625 > > Committed: https://crrev.com/bd322a00b660027df64b4e7cb2452e1daeeb334a > Cr-Commit-Position: refs/heads/master@{#372589} TBR=dbeam@chromium.org,tsergeant@chromium.org,yingran@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=425625

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -643 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/history/compiled_resources.gyp View 1 chunk +1 line, -4 lines 0 comments Download
D chrome/browser/resources/history/externs.js View 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/browser/resources/history/history.js View 2 chunks +38 lines, -5 lines 0 comments Download
D chrome/browser/resources/md_history/compiled_resources.gyp View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/resources/md_history/history_card.html View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/resources/md_history/history_card.js View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/resources/md_history/history_card_manager.html View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/resources/md_history/history_card_manager.js View 1 chunk +0 lines, -165 lines 0 comments Download
D chrome/browser/resources/md_history/history_item.html View 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/browser/resources/md_history/history_item.js View 1 chunk +0 lines, -94 lines 0 comments Download
M chrome/browser/ui/webui/browsing_history_handler.cc View 5 chunks +12 lines, -25 lines 0 comments Download
M ui/webui/resources/js/cr/ui/position_util.js View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
calamity
Created Revert of MD History: Add basic material design history cards and history items
4 years, 10 months ago (2016-02-01 03:34:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1654703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1654703002/1
4 years, 10 months ago (2016-02-01 03:34:52 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 03:36:04 UTC) #4
Failed to apply patch for ui/webui/resources/js/cr/ui/position_util.js:
While running git apply --index -3 -p1;
  error: patch failed: ui/webui/resources/js/cr/ui/position_util.js:226
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: ui/webui/resources/js/cr/ui/position_util.js: patch does not apply

Patch:       ui/webui/resources/js/cr/ui/position_util.js
Index: ui/webui/resources/js/cr/ui/position_util.js
diff --git a/ui/webui/resources/js/cr/ui/position_util.js
b/ui/webui/resources/js/cr/ui/position_util.js
index
c0c483b919685e4d37e1a3919eba3a5ed368f411..14b29d92d97b9d3d592255e0787d15c820979376
100644
--- a/ui/webui/resources/js/cr/ui/position_util.js
+++ b/ui/webui/resources/js/cr/ui/position_util.js
@@ -226,9 +226,8 @@
    * @param {number} x The client x position.
    * @param {number} y The client y position.
    * @param {!HTMLElement} popupElement The popup element we are positioning.
-   * @param {cr.ui.AnchorType=} opt_anchorType The type of anchoring we want.
-   */
-  function positionPopupAtPoint(x, y, popupElement, opt_anchorType) {
+   */
+  function positionPopupAtPoint(x, y, popupElement) {
     var rect = {
       left: x,
       top: y,
@@ -237,9 +236,7 @@
       right: x,
       bottom: y
     };
-
-    var anchorType = opt_anchorType || AnchorType.BELOW;
-    positionPopupAroundRect(rect, popupElement, anchorType);
+    positionPopupAroundRect(rect, popupElement, AnchorType.BELOW);
   }
 
   // Export

Powered by Google App Engine
This is Rietveld 408576698