chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js - Issue 1654683002: PDF: Allow external navigation links in PDF bookmarks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js

Issue 1654683002: PDF: Allow external navigation links in PDF bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js

diff --git a/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js b/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js

index 7905ea4ec3454b1b00eda2ce98401fafcb1f3e51..9d6399070e7a82868314a24996011b8945cd01d2 100644

--- a/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js

+++ b/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js

@@ -65,6 +65,8 @@

onClick: function() {

if (this.bookmark.hasOwnProperty('page'))

this.fire('change-page', {page: this.bookmark.page});

+ else if (this.bookmark.hasOwnProperty('uri'))

+ this.fire('navigate', {uri: this.bookmark.uri, newtab: true});

onEnter_: function(e) {

« no previous file with comments | « no previous file | chrome/browser/resources/pdf/pdf.js » ('j') | no next file with comments »