PDF: Allow external navigation links in PDF bookmarks

chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js

Index: chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js
diff --git a/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js b/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js
index 7905ea4ec3454b1b00eda2ce98401fafcb1f3e51..9d6399070e7a82868314a24996011b8945cd01d2 100644
--- a/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js
+++ b/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js
@@ -65,6 +65,8 @@
     onClick: function() {
       if (this.bookmark.hasOwnProperty('page'))
         this.fire('change-page', {page: this.bookmark.page});
+      else if (this.bookmark.hasOwnProperty('uri'))
+        this.fire('navigate', {uri: this.bookmark.uri, newtab: true});

[raymes, 2016/02/01 04:44:32]

perhaps just reuse the change-page event?

[tsergeant, 2016/02/01 06:01:00]

I'm not convinced that this is an improvement. They're fairly different things
(`change-page` isn't a good name to cover both actions), and they get routed to
different places in pdf.js (navigator vs viewport).

[raymes, 2016/02/02 00:20:14]

Ah I assumed that change-page was only used here, so we could change it into a
"bookmark-clicked" type event. But that's not the case. This seems ok to me.

     },
 
     onEnter_: function(e) {