PDF: Allow external navigation links in PDF bookmarks

pdf/pdfium/pdfium_engine.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_engine.h"
 
 #include <math.h>
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 409 matching lines @@
     api_string_adapter.Close(FPDFBookmark_GetTitle(
         bookmark, api_string_adapter.GetData(), buffer_size));
   }
   dict.Set(pp::Var("title"), pp::Var(base::UTF16ToUTF8(title)));
 
   FPDF_DEST dest = FPDFBookmark_GetDest(doc, bookmark);
   // Some bookmarks don't have a page to select.
   if (dest) {
     int page_index = FPDFDest_GetPageIndex(doc, dest);
     dict.Set(pp::Var("page"), pp::Var(page_index));
+  } else {
+    // Extract URI for bookmarks linking to an external page.
+    FPDF_ACTION action = FPDFBookmark_GetAction(bookmark);
+    buffer_size = FPDFAction_GetURIPath(doc, action, NULL, 0);

[raymes, 2016/02/01 04:44:32]

nit: nullptr

[tsergeant, 2016/02/01 06:01:00]

Done (and the one above)

+    std::string uri;

[raymes, 2016/02/01 04:44:32]

nit: move into if statement 

[tsergeant, 2016/02/01 06:01:00]

Done.

+    if (buffer_size > 0) {
+      PDFiumAPIStringBufferAdapter<std::string>
+          api_string_adapter(&uri, buffer_size, true);
+      api_string_adapter.Close(FPDFAction_GetURIPath(
+          doc, action, api_string_adapter.GetData(), buffer_size));
+      dict.Set(pp::Var("uri"), pp::Var(uri));
+    }
   }
 
   pp::VarArray children;
 
   // Don't trust PDFium to handle circular bookmarks.
   const unsigned int kMaxDepth = 128;
   if (depth < kMaxDepth) {
     int child_index = 0;
     std::set<FPDF_BOOKMARK> seen_bookmarks;
     for (FPDF_BOOKMARK child_bookmark =
@@ skipping 3519 matching lines @@
     double* height) {
   FPDF_DOCUMENT doc = FPDF_LoadMemDocument(pdf_buffer, pdf_buffer_size, NULL);
   if (!doc)
     return false;
   bool success = FPDF_GetPageSizeByIndex(doc, page_number, width, height) != 0;
   FPDF_CloseDocument(doc);
   return success;
 }
 
 }  // namespace chrome_pdf