third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 1654653002: Canvas2d: Implement rerouting event by hit region's control.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1654653002: Canvas2d: Implement rerouting event by hit region's control. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix bot errors Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/input/EventHandler.cpp ('K') | « third_party/WebKit/Source/platform/PlatformMouseEvent.h ('k') | third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index 972c7f4146ed1d74a3e1c4b0525245a233985c7b..110ddd4b1af7ca7fa9f62997166c6f92b397306e 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -5814,7 +5814,8 @@ TEST_P(ParameterizedWebFrameTest, SimulateFragmentAnchorMiddleClick)

destination.setFragmentIdentifier("test");

RefPtrWillBeRawPtr<Event> event = MouseEvent::create(EventTypeNames::click, false, false,

- document->domWindow(), 0, 0, 0, 0, 0, 0, 0, PlatformEvent::NoModifiers, 1, 0, nullptr, 0);

+ document->domWindow(), 0, 0, 0, 0, 0, 0, 0, PlatformEvent::NoModifiers, 1, 0, nullptr, 0,

+ PlatformMouseEvent::RealOrIndistinguishable, String());

FrameLoadRequest frameRequest(document, ResourceRequest(destination));

frameRequest.setTriggeringEvent(event);

toLocalFrame(webViewHelper.webViewImpl()->page()->mainFrame())->loader().load(frameRequest);

@@ -5863,7 +5864,8 @@ TEST_P(ParameterizedWebFrameTest, ModifiedClickNewWindow)

// ctrl+click event

RefPtrWillBeRawPtr<Event> event = MouseEvent::create(EventTypeNames::click, false, false,

- document->domWindow(), 0, 0, 0, 0, 0, 0, 0, PlatformEvent::CtrlKey, 0, 0, nullptr, 0);

+ document->domWindow(), 0, 0, 0, 0, 0, 0, 0, PlatformEvent::CtrlKey, 0, 0, nullptr, 0,

+ PlatformMouseEvent::RealOrIndistinguishable, String());

FrameLoadRequest frameRequest(document, ResourceRequest(destination));

frameRequest.setTriggeringEvent(event);

UserGestureIndicator gesture(DefinitelyProcessingUserGesture);