third_party/WebKit/Source/core/events/WheelEvent.cpp - Issue 1654653002: Canvas2d: Implement rerouting event by hit region's control.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/WheelEvent.cpp

Issue 1654653002: Canvas2d: Implement rerouting event by hit region's control. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix bot errors Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/events/MouseEventInit.idl ('k') | third_party/WebKit/Source/core/html/HTMLCanvasElement.h » ('j') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/events/WheelEvent.cpp

diff --git a/third_party/WebKit/Source/core/events/WheelEvent.cpp b/third_party/WebKit/Source/core/events/WheelEvent.cpp

index c27be32420f071d5305bedc9f892b789e8e2514e..3f4c15b742a68d512dc8d75f68b73d1ded2b2087 100644

--- a/third_party/WebKit/Source/core/events/WheelEvent.cpp

+++ b/third_party/WebKit/Source/core/events/WheelEvent.cpp

@@ -76,7 +76,10 @@ WheelEvent::WheelEvent(const FloatPoint& wheelTicks, const FloatPoint& rawDelta,

bool canScroll, int resendingPluginId, bool hasPreciseScrollingDeltas, RailsMode railsMode)

: MouseEvent(EventTypeNames::wheel, true, true, view, 0, screenLocation.x(), screenLocation.y(),

windowLocation.x(), windowLocation.y(), 0, 0, modifiers, 0, buttons,

- nullptr, platformTimeStamp, PlatformMouseEvent::RealOrIndistinguishable)

+ nullptr, platformTimeStamp, PlatformMouseEvent::RealOrIndistinguishable,

+ // TODO(zino): Should support canvas hit region because the wheel event

+ // is a kind of mouse event. Please see http://crbug.com/594075

+ String())

, m_wheelDelta(wheelTicks.x() * TickMultiplier, wheelTicks.y() * TickMultiplier)

, m_deltaX(-rawDelta.x())

, m_deltaY(-rawDelta.y())