Issue 165463003: Copies DockInfoGtk into WindowFinder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165463003: Copies DockInfoGtk into WindowFinder. (Closed)

Created:
6 years, 10 months ago by sky

Modified:
6 years, 10 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Copies DockInfoGtk into WindowFinder. I'm going to nuke DockInfo soonish. This is a stup in that direction. BUG=none TEST=none R=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251342

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -57 lines)			Patch
M	chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h	View	3 chunks	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc	View	5 chunks	+16 lines, -18 lines	0 comments	Download
A	chrome/browser/ui/gtk/tabs/window_finder.h	View	1 chunk	+22 lines, -0 lines	0 comments	Download
A +	chrome/browser/ui/gtk/tabs/window_finder.cc	View	3 chunks	+5 lines, -32 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Elliot Glaysher

So the idea is to get rid of the whole DockInfo mess? LGTM.

6 years, 10 months ago (2014-02-14 01:13:05 UTC) #2

sky

Mess, eh? Er, yes. On Thu, Feb 13, 2014 at 5:13 PM, <erg@chromium.org> wrote: > ...

6 years, 10 months ago (2014-02-14 15:52:06 UTC) #3

sky

6 years, 10 months ago (2014-02-14 16:20:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r251342 (presubmit successful).