Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2303)

Unified Diff: chrome/browser/chromeos/keyboard_driven_event_rewriter.cc

Issue 165463002: event-rewrite: Clean up how events are rewritten. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix-debug Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/keyboard_driven_event_rewriter.cc
diff --git a/chrome/browser/chromeos/keyboard_driven_event_rewriter.cc b/chrome/browser/chromeos/keyboard_driven_event_rewriter.cc
index 389757f8f118f9687b4188235ab1f5b4e5dcd661..9f9ef7850a4c03092512284cff3fa715cebbeb37 100644
--- a/chrome/browser/chromeos/keyboard_driven_event_rewriter.cc
+++ b/chrome/browser/chromeos/keyboard_driven_event_rewriter.cc
@@ -8,7 +8,7 @@
#include "chrome/browser/chromeos/login/user_manager.h"
#include "chrome/browser/chromeos/system/input_device_settings.h"
-#include "ui/events/event.h"
+#include "ui/events/event_utils.h"
namespace chromeos {
@@ -35,35 +35,34 @@ KeyboardDrivenEventRewriter::KeyboardDrivenEventRewriter() {}
KeyboardDrivenEventRewriter::~KeyboardDrivenEventRewriter() {}
bool KeyboardDrivenEventRewriter::RewriteIfKeyboardDrivenOnLoginScreen(
- ui::KeyEvent* event) {
+ XEvent* event) {
if (!ShouldStripModifiersForArrowKeysAndEnter())
return false;
return RewriteEvent(event);
}
-bool KeyboardDrivenEventRewriter::RewriteForTesting(ui::KeyEvent* event) {
+bool KeyboardDrivenEventRewriter::RewriteForTesting(XEvent* event) {
return RewriteEvent(event);
}
-bool KeyboardDrivenEventRewriter::RewriteEvent(ui::KeyEvent* event) {
- if ((event->flags() & kModifierMask) != kModifierMask)
+bool KeyboardDrivenEventRewriter::RewriteEvent(XEvent* event) {
+ int flags = ui::EventFlagsFromNative(event);
+ if ((flags & kModifierMask) != kModifierMask)
return false;
-
- if (event->key_code() != ui::VKEY_LEFT &&
- event->key_code() != ui::VKEY_RIGHT &&
- event->key_code() != ui::VKEY_UP &&
- event->key_code() != ui::VKEY_DOWN &&
- event->key_code() != ui::VKEY_RETURN &&
- event->key_code() != ui::VKEY_F6) {
+ ui::KeyboardCode key_code = ui::KeyboardCodeFromNative(event);
+
+ if (key_code != ui::VKEY_LEFT &&
+ key_code != ui::VKEY_RIGHT &&
+ key_code != ui::VKEY_UP &&
+ key_code != ui::VKEY_DOWN &&
+ key_code != ui::VKEY_RETURN &&
+ key_code != ui::VKEY_F6) {
return false;
}
- XEvent* xev = event->native_event();
- XKeyEvent* xkey = &(xev->xkey);
+ XKeyEvent* xkey = &(event->xkey);
xkey->state &= ~(ControlMask | Mod1Mask | ShiftMask);
- event->set_flags(event->flags() & ~kModifierMask);
- event->NormalizeFlags();
return true;
}

Powered by Google App Engine
This is Rietveld 408576698