Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 165453003: Cleanup: Remove WebFormElement include from autofill_manager_unittest.cc (Closed)

Created:
6 years, 10 months ago by tfarina
Modified:
6 years, 10 months ago
Reviewers:
Ilya Sherman, Jói, blundell
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Cleanup: Remove WebFormElement include from autofill_manager_unittest.cc Apparently this type is not used by the unit tests and allow us to remove another entry from the DEPS file. BUG=140037 TEST=unit_tests R=joi@chromium.org,blundell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251328

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M components/autofill/core/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 4 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
tfarina
6 years, 10 months ago (2014-02-14 03:23:29 UTC) #1
Ilya Sherman
Nice! LGTM.
6 years, 10 months ago (2014-02-14 05:03:20 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 10 months ago (2014-02-14 05:03:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/165453003/1
6 years, 10 months ago (2014-02-14 05:04:11 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 08:09:05 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=202079
6 years, 10 months ago (2014-02-14 08:09:06 UTC) #6
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 10 months ago (2014-02-14 08:10:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/165453003/1
6 years, 10 months ago (2014-02-14 08:11:10 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 10:49:07 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=202157
6 years, 10 months ago (2014-02-14 10:49:07 UTC) #10
blundell
LGTM, thanks!
6 years, 10 months ago (2014-02-14 10:51:04 UTC) #11
Jói
LGTM
6 years, 10 months ago (2014-02-14 11:09:08 UTC) #12
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-14 11:48:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/165453003/1
6 years, 10 months ago (2014-02-14 11:48:51 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 15:18:17 UTC) #15
Message was sent while issue was closed. 
Change committed as 251328

Powered by Google App Engine
This is Rietveld 408576698