Issue 1654523002: Use JS_ExpandKeywordParams() in app.response()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1654523002: Use JS_ExpandKeywordParams() in app.response() (Closed)

Created:
4 years, 10 months ago by Tom Sepez

Modified:
4 years, 10 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -73 lines)			Patch
M	fpdfsdk/src/javascript/app.cpp	View	1	1 chunk	+30 lines, -57 lines	0 comments	Download
M	samples/pdfium_test.cc	View		3 chunks	+27 lines, -0 lines	0 comments	Download
A +	testing/resources/javascript/app_repsonse.in	View		1 chunk	+20 lines, -16 lines	0 comments	Download
A	testing/resources/javascript/app_repsonse_expected.txt	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Tom Sepez

4 years, 10 months ago (2016-02-01 18:24:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3859258ebe9e81e1f766b57e7f78c786ae4ed495 (presubmit successful).