Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: remoting/protocol/channel_dispatcher_base.cc

Issue 1654513003: Simplify message parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_done
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/channel_dispatcher_base.cc
diff --git a/remoting/protocol/channel_dispatcher_base.cc b/remoting/protocol/channel_dispatcher_base.cc
index cd0823b2835b467a4aed4bdff3ed4316d7c65d3b..36d60dde564fe4d65cc19ccb77e1d8bd46c0b1c0 100644
--- a/remoting/protocol/channel_dispatcher_base.cc
+++ b/remoting/protocol/channel_dispatcher_base.cc
@@ -47,12 +47,21 @@ void ChannelDispatcherBase::OnChannelReady(
base::Bind(&ChannelDispatcherBase::OnReadWriteFailed,
base::Unretained(this)));
reader_.StartReading(channel_.get(),
+ base::Bind(&ChannelDispatcherBase::OnIncomingMessage,
+ base::Unretained(this)),
base::Bind(&ChannelDispatcherBase::OnReadWriteFailed,
base::Unretained(this)));
event_handler_->OnChannelInitialized(this);
}
+void ChannelDispatcherBase::OnIncomingMessage(
+ scoped_ptr<CompoundBuffer> message) {
+ // By default incoming message are not expected. Child classes override
+ // OnIncomingMessage() if the want to handle incoming messages.
+ LOG(ERROR) << "Received unexpected message on " << channel_name();
+}
+
void ChannelDispatcherBase::OnReadWriteFailed(int error) {
event_handler_->OnChannelError(this, CHANNEL_CONNECTION_ERROR);
}

Powered by Google App Engine
This is Rietveld 408576698