|
|
Description[libfuzzer] Fix compile error from missing courgette_fuzzer.cc include.
https://codereview.chromium.org/1629703002/ missed a spot and broke
build with libfuzzer. This fixes it.
TBR=krasin@chromium.org
NOTRY=true
Committed: https://crrev.com/ed2fc4da0ab8e0a56e978e78a4ff77fd2c7fdc0b
Cr-Commit-Position: refs/heads/master@{#372475}
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
Description was changed from ========== [libfuzzer] Fix compile bug by updating courgette_fuzzer.cc include. https://codereview.chromium.org/1629703002/ missed a spot and broke build with libfuzzer. This fixes it. ========== to ========== [libfuzzer] Fix compile bug by updating courgette_fuzzer.cc include. https://codereview.chromium.org/1629703002/ missed a spot and broke build with libfuzzer. This fixes it. TBR: krasin@chromium.org ==========
huangs@chromium.org changed reviewers: + dcheng@chromium.org, krasin@chromium.org
Description was changed from ========== [libfuzzer] Fix compile bug by updating courgette_fuzzer.cc include. https://codereview.chromium.org/1629703002/ missed a spot and broke build with libfuzzer. This fixes it. TBR: krasin@chromium.org ========== to ========== [libfuzzer] Fix compile error from missing courgette_fuzzer.cc include. https://codereview.chromium.org/1629703002/ missed a spot and broke build with libfuzzer. This fixes it. TBR: krasin@chromium.org ==========
The CQ bit was checked by huangs@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1654503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1654503002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was unchecked by huangs@chromium.org
Description was changed from ========== [libfuzzer] Fix compile error from missing courgette_fuzzer.cc include. https://codereview.chromium.org/1629703002/ missed a spot and broke build with libfuzzer. This fixes it. TBR: krasin@chromium.org ========== to ========== [libfuzzer] Fix compile error from missing courgette_fuzzer.cc include. https://codereview.chromium.org/1629703002/ missed a spot and broke build with libfuzzer. This fixes it. TBR=krasin@chromium.org NOTRY=true ==========
The CQ bit was checked by huangs@chromium.org
On 2016/01/29 at 23:45:26, commit-bot wrote: > No L-G-T-M from a valid reviewer yet. Only full committers are accepted. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. There's a typo in testing/libfuzzer/fuzzers/zlib_uncompress_fuzzer.cc as well: diff --git a/testing/libfuzzer/fuzzers/zlib_uncompress_fuzzer.cc b/testing/libfuzzer/fuzzers/zlib_uncompress_fuzzer.cc index 1543b70..680f8bf 100644 --- a/testing/libfuzzer/fuzzers/zlib_uncompress_fuzzer.cc +++ b/testing/libfuzzer/fuzzers/zlib_uncompress_fuzzer.cc @@ -15,7 +15,7 @@ extern "C" int LLVMFuzzerTestOneInput(const unsigned char *data, size_t size) { uLongf buffer_length = (uLongf)BUF_SIZE; memset(buffer, 0, BUF_SIZE); if (Z_OK != uncompress(buffer, &buffer_length, data, - static_cast<uLong>size)) { + static_cast<uLong>(size))) { delete[] buffer; return 0; }
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1654503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1654503002/1
I didn't change that. Should it be bundled into this CL?
On 2016/01/29 at 23:47:38, huangs wrote: > I didn't change that. Should it be bundled into this CL? Ah... I'll find the guilty party then =) LGTM, thanks.
Thanks!
Message was sent while issue was closed.
Description was changed from ========== [libfuzzer] Fix compile error from missing courgette_fuzzer.cc include. https://codereview.chromium.org/1629703002/ missed a spot and broke build with libfuzzer. This fixes it. TBR=krasin@chromium.org NOTRY=true ========== to ========== [libfuzzer] Fix compile error from missing courgette_fuzzer.cc include. https://codereview.chromium.org/1629703002/ missed a spot and broke build with libfuzzer. This fixes it. TBR=krasin@chromium.org NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [libfuzzer] Fix compile error from missing courgette_fuzzer.cc include. https://codereview.chromium.org/1629703002/ missed a spot and broke build with libfuzzer. This fixes it. TBR=krasin@chromium.org NOTRY=true ========== to ========== [libfuzzer] Fix compile error from missing courgette_fuzzer.cc include. https://codereview.chromium.org/1629703002/ missed a spot and broke build with libfuzzer. This fixes it. TBR=krasin@chromium.org NOTRY=true Committed: https://crrev.com/ed2fc4da0ab8e0a56e978e78a4ff77fd2c7fdc0b Cr-Commit-Position: refs/heads/master@{#372475} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ed2fc4da0ab8e0a56e978e78a4ff77fd2c7fdc0b Cr-Commit-Position: refs/heads/master@{#372475}
Message was sent while issue was closed.
lgtm Thanks! |