Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: ui/views/widget/widget_unittest.cc

Issue 1654433005: Revert of Minor fixes for WidgetRemovalsObserver::OnWillRemoveView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/widget/widget_removals_observer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget_unittest.cc
diff --git a/ui/views/widget/widget_unittest.cc b/ui/views/widget/widget_unittest.cc
index 7603ee761d0e693df8bd9d7d2590f60bd654b89b..57235012eee16f786ca0c6d8b49c0f1c7aca4366 100644
--- a/ui/views/widget/widget_unittest.cc
+++ b/ui/views/widget/widget_unittest.cc
@@ -29,7 +29,6 @@
#include "ui/views/widget/native_widget_delegate.h"
#include "ui/views/widget/root_view.h"
#include "ui/views/widget/widget_deletion_observer.h"
-#include "ui/views/widget/widget_removals_observer.h"
#include "ui/views/window/dialog_delegate.h"
#include "ui/views/window/native_frame_view.h"
@@ -3445,72 +3444,5 @@
EXPECT_EQ(scale_factor, view->last_scale_factor());
}
-namespace {
-
-class TestWidgetRemovalsObserver : public WidgetRemovalsObserver {
- public:
- TestWidgetRemovalsObserver() {}
- ~TestWidgetRemovalsObserver() override {}
-
- void OnWillRemoveView(Widget* widget, View* view) override {
- removed_views_.insert(view);
- }
-
- bool DidRemoveView(View* view) {
- return removed_views_.find(view) != removed_views_.end();
- }
-
- private:
- std::set<View*> removed_views_;
-};
-
-}
-
-// Test that WidgetRemovalsObserver::OnWillRemoveView is called when deleting
-// a view.
-TEST_F(WidgetTest, WidgetRemovalsObserverCalled) {
- WidgetAutoclosePtr widget(CreateTopLevelPlatformWidget());
- TestWidgetRemovalsObserver removals_observer;
- widget->AddRemovalsObserver(&removals_observer);
-
- View* parent = new View();
- widget->client_view()->AddChildView(parent);
-
- View* child = new View();
- parent->AddChildView(child);
-
- widget->client_view()->RemoveChildView(parent);
- EXPECT_TRUE(removals_observer.DidRemoveView(parent));
- EXPECT_FALSE(removals_observer.DidRemoveView(child));
-
- widget->RemoveRemovalsObserver(&removals_observer);
-}
-
-// Test that WidgetRemovalsObserver::OnWillRemoveView is called when moving
-// a view from one widget to another, but not when moving a view within
-// the same widget.
-TEST_F(WidgetTest, WidgetRemovalsObserverCalledWhenMovingBetweenWidgets) {
- WidgetAutoclosePtr widget(CreateTopLevelPlatformWidget());
- TestWidgetRemovalsObserver removals_observer;
- widget->AddRemovalsObserver(&removals_observer);
-
- View* parent = new View();
- widget->client_view()->AddChildView(parent);
-
- View* child = new View();
- widget->client_view()->AddChildView(child);
-
- // Reparenting the child shouldn't call the removals observer.
- parent->AddChildView(child);
- EXPECT_FALSE(removals_observer.DidRemoveView(child));
-
- // Moving the child to a different widget should call the removals observer.
- WidgetAutoclosePtr widget2(CreateTopLevelPlatformWidget());
- widget2->client_view()->AddChildView(child);
- EXPECT_TRUE(removals_observer.DidRemoveView(child));
-
- widget->RemoveRemovalsObserver(&removals_observer);
-}
-
} // namespace test
} // namespace views
« no previous file with comments | « ui/views/widget/widget_removals_observer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698