Chromium Code Reviews Chromium Code Reviews
Issue
1654433005:
Revert of Minor fixes for WidgetRemovalsObserver::OnWillRemoveView (Closed)
DescriptionRevert of Minor fixes for WidgetRemovalsObserver::OnWillRemoveView (patchset #4 id:60001 of https://codereview.chromium.org/1624343003/ )
Reason for revert:
Causing a failure on the Linux Chromium OS ASan LSan Tests bot.
Link to failure log:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/9195/steps/views_unittests/logs/stdio
First error from log (7 in total related to widget tests):
Indirect leak of 512 byte(s) in 1 object(s) allocated from:
#0 0x55bbab in operator new(unsigned long) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__1_/build/src/out/Release/views_unittests+0x55bbab)
#1 0xe8002c in allocate /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/ext/new_allocator.h:92:27
#2 0xe8002c in _M_allocate_node /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_deque.h:525
#3 0xe8002c in _M_create_nodes /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_deque.h:619
#4 0xe8002c in _M_initialize_map /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_deque.h:593
#5 0xe8002c in _Deque_base /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_deque.h:452
#6 0xe8002c in deque /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_deque.h:772
#7 0xe8002c in ui::EventHandler::EventHandler() ui/events/event_handler.cc:12
#8 0x103aa66 in views::View::View() ui/views/view.cc:100:7
#9 0xb1cb16 in views::test::WidgetTest_WidgetRemovalsObserverCalled_Test::TestBody() ui/views/widget/widget_unittest.cc:3479:21
#10 0xd196ab in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12
#11 0xd196ab in testing::Test::Run() testing/gtest/src/gtest.cc:2474
#12 0xd1ba77 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:5
#13 0xd1c86a in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:5
#14 0xd31660 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:11
#15 0xd30a8b in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12
#16 0xd30a8b in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255
#17 0xcdd3a6 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:10
#18 0xcdd3a6 in base::TestSuite::Run() base/test/test_suite.cc:231
#19 0xcd0642 in Run base/callback.h:394:12
#20 0xcd0642 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:206
#21 0xcd02dc in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:445:10
#22 0x981c94 in main ui/views/run_all_unittests.cc:53:10
#23 0x7ff93a18876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226
Original issue's description:
> Minor fixes for WidgetRemovalsObserver::OnWillRemoveView
>
> Previously it was called whenever a view was removed, even if it
> was just moved within the same widget.
>
> Now it's only called if it's actually removed entirely, or moved
> to a different widget.
>
> BUG=581127
>
> Committed: https://crrev.com/b5c59b11b49b910758899d8b3261a08665ca3fa0
> Cr-Commit-Position: refs/heads/master@{#372448}
TBR=sky@chromium.org,dmazzoni@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581127
Committed: https://crrev.com/33b385196c44d933b2aaf1181f34617db0fbd6a2
Cr-Commit-Position: refs/heads/master@{#372489}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
|||||||||||||||||||||||||||||||||||||
