Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 1654433002: combine vertical overlapping edges (Closed)

Created:
4 years, 10 months ago by caryclark
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

combine vertical overlapping edges Paths outside clips, and sometimes paths inside clips, devolve to multiple adjacent or overlapping vertical edges. Combine these edges when possible to reduce the overall edge count. R=reed@google.com BUG=573166 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1654433002 Committed: https://skia.googlesource.com/skia/+/afd25f703d9bbc9cd80b03b63b30abd14db4911d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -2 lines) Patch
M src/core/SkEdgeBuilder.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/core/SkEdgeBuilder.cpp View 4 chunks +76 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
caryclark
4 years, 10 months ago (2016-01-29 19:56:49 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1654433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1654433002/1
4 years, 10 months ago (2016-01-29 19:57:07 UTC) #4
reed1
lgtm
4 years, 10 months ago (2016-01-30 00:56:58 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-30 17:59:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1654433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1654433002/1
4 years, 10 months ago (2016-01-30 21:55:54 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-01-30 22:07:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/afd25f703d9bbc9cd80b03b63b30abd14db4911d

Powered by Google App Engine
This is Rietveld 408576698