Source/web/WebFrameImpl.cpp - Issue 165443003: Pass implementation object to supplemental classes by reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebFrameImpl.cpp

Issue 165443003: Pass implementation object to supplemental classes by reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebFrameImpl.cpp

diff --git a/Source/web/WebFrameImpl.cpp b/Source/web/WebFrameImpl.cpp

index 8a611c08c2e6928459a77feef36f5cd562d848fc..cec8118e30fef3ba5263fbf6e4cb944f7390775d 100644

--- a/Source/web/WebFrameImpl.cpp

+++ b/Source/web/WebFrameImpl.cpp

@@ -754,8 +754,9 @@ WebFrame* WebFrameImpl::findChildByExpression(const WebString& xpath) const

return 0;

Document* document = frame()->document();

+ ASSERT(document);

- RefPtr<XPathResult> xpathResult = DocumentXPathEvaluator::evaluate(document, xpath, document, 0, XPathResult::ORDERED_NODE_ITERATOR_TYPE, 0, IGNORE_EXCEPTION);

+ RefPtr<XPathResult> xpathResult = DocumentXPathEvaluator::evaluate(*document, xpath, document, 0, XPathResult::ORDERED_NODE_ITERATOR_TYPE, 0, IGNORE_EXCEPTION);

if (!xpathResult)

return 0;

« no previous file with comments | « Source/web/WebDragData.cpp ('k') | Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »