Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 165443003: Pass implementation object to supplemental classes by reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/DatabaseClientImpl.cpp ('k') | Source/web/FullscreenController.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 FrameLoaderClientImpl::~FrameLoaderClientImpl() 110 FrameLoaderClientImpl::~FrameLoaderClientImpl()
111 { 111 {
112 } 112 }
113 113
114 void FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld(DOMWrapperWorld* world) 114 void FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld(DOMWrapperWorld* world)
115 { 115 {
116 if (m_webFrame->client()) { 116 if (m_webFrame->client()) {
117 m_webFrame->client()->didClearWindowObject(m_webFrame, world->worldId()) ; 117 m_webFrame->client()->didClearWindowObject(m_webFrame, world->worldId()) ;
118 Document* document = m_webFrame->frame()->document(); 118 Document* document = m_webFrame->frame()->document();
119 if (document) { 119 if (document) {
120 WheelController::from(document); 120 WheelController::from(*document);
121 if (RuntimeEnabledFeatures::deviceMotionEnabled()) 121 if (RuntimeEnabledFeatures::deviceMotionEnabled())
122 DeviceMotionController::from(document); 122 DeviceMotionController::from(*document);
123 if (RuntimeEnabledFeatures::deviceOrientationEnabled()) 123 if (RuntimeEnabledFeatures::deviceOrientationEnabled())
124 DeviceOrientationController::from(document); 124 DeviceOrientationController::from(*document);
125 } 125 }
126 } 126 }
127 } 127 }
128 128
129 void FrameLoaderClientImpl::documentElementAvailable() 129 void FrameLoaderClientImpl::documentElementAvailable()
130 { 130 {
131 if (m_webFrame->client()) 131 if (m_webFrame->client())
132 m_webFrame->client()->didCreateDocumentElement(m_webFrame); 132 m_webFrame->client()->didCreateDocumentElement(m_webFrame);
133 } 133 }
134 134
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
497 { 497 {
498 // FIXME: why might the webview be null? http://b/1234461 498 // FIXME: why might the webview be null? http://b/1234461
499 WebViewImpl* webview = m_webFrame->viewImpl(); 499 WebViewImpl* webview = m_webFrame->viewImpl();
500 if (webview && webview->client()) 500 if (webview && webview->client())
501 webview->client()->didStopLoading(); 501 webview->client()->didStopLoading();
502 } 502 }
503 503
504 void FrameLoaderClientImpl::loadURLExternally(const ResourceRequest& request, Na vigationPolicy policy, const String& suggestedName) 504 void FrameLoaderClientImpl::loadURLExternally(const ResourceRequest& request, Na vigationPolicy policy, const String& suggestedName)
505 { 505 {
506 if (m_webFrame->client()) { 506 if (m_webFrame->client()) {
507 DocumentFullscreen::webkitCancelFullScreen(m_webFrame->frame()->document ()); 507 ASSERT(m_webFrame->frame()->document());
508 DocumentFullscreen::webkitCancelFullScreen(*m_webFrame->frame()->documen t());
508 WrappedResourceRequest webreq(request); 509 WrappedResourceRequest webreq(request);
509 m_webFrame->client()->loadURLExternally( 510 m_webFrame->client()->loadURLExternally(
510 m_webFrame, webreq, static_cast<WebNavigationPolicy>(policy), sugges tedName); 511 m_webFrame, webreq, static_cast<WebNavigationPolicy>(policy), sugges tedName);
511 } 512 }
512 } 513 }
513 514
514 bool FrameLoaderClientImpl::navigateBackForward(int offset) const 515 bool FrameLoaderClientImpl::navigateBackForward(int offset) const
515 { 516 {
516 WebViewImpl* webview = m_webFrame->viewImpl(); 517 WebViewImpl* webview = m_webFrame->viewImpl();
517 if (!webview->client()) 518 if (!webview->client())
(...skipping 271 matching lines...) Expand 10 before | Expand all | Expand 10 after
789 return adoptPtr(m_webFrame->client()->createApplicationCacheHost(m_webFrame, client)); 790 return adoptPtr(m_webFrame->client()->createApplicationCacheHost(m_webFrame, client));
790 } 791 }
791 792
792 void FrameLoaderClientImpl::didStopAllLoaders() 793 void FrameLoaderClientImpl::didStopAllLoaders()
793 { 794 {
794 if (m_webFrame->client()) 795 if (m_webFrame->client())
795 m_webFrame->client()->didAbortLoading(m_webFrame); 796 m_webFrame->client()->didAbortLoading(m_webFrame);
796 } 797 }
797 798
798 } // namespace blink 799 } // namespace blink
OLDNEW
« no previous file with comments | « Source/web/DatabaseClientImpl.cpp ('k') | Source/web/FullscreenController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698