Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 165443003: Pass implementation object to supplemental classes by reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/frame/Frame.cpp ('k') | Source/core/frame/NavigatorID.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 2012 matching lines...) Expand 10 before | Expand all | Expand 10 after
2023 void FrameView::performPostLayoutTasks() 2023 void FrameView::performPostLayoutTasks()
2024 { 2024 {
2025 TRACE_EVENT0("webkit", "FrameView::performPostLayoutTasks"); 2025 TRACE_EVENT0("webkit", "FrameView::performPostLayoutTasks");
2026 RefPtr<FrameView> protect(this); 2026 RefPtr<FrameView> protect(this);
2027 2027
2028 m_postLayoutTasksTimer.stop(); 2028 m_postLayoutTasksTimer.stop();
2029 2029
2030 m_frame->selection().setCaretRectNeedsUpdate(); 2030 m_frame->selection().setCaretRectNeedsUpdate();
2031 m_frame->selection().updateAppearance(); 2031 m_frame->selection().updateAppearance();
2032 2032
2033 ASSERT(m_frame->document());
2033 if (m_nestedLayoutCount <= 1) { 2034 if (m_nestedLayoutCount <= 1) {
2034 if (m_firstLayoutCallbackPending) { 2035 if (m_firstLayoutCallbackPending) {
2035 m_firstLayoutCallbackPending = false; 2036 m_firstLayoutCallbackPending = false;
2036 m_frame->loader().didFirstLayout(); 2037 m_frame->loader().didFirstLayout();
2037 } 2038 }
2038 2039
2039 // Ensure that we always send this eventually. 2040 // Ensure that we always send this eventually.
2040 if (!m_frame->document()->parsing() && m_frame->loader().stateMachine()- >committedFirstRealDocumentLoad()) 2041 if (!m_frame->document()->parsing() && m_frame->loader().stateMachine()- >committedFirstRealDocumentLoad())
2041 m_isVisuallyNonEmpty = true; 2042 m_isVisuallyNonEmpty = true;
2042 2043
2043 // If the layout was done with pending sheets, we are not in fact visual ly non-empty yet. 2044 // If the layout was done with pending sheets, we are not in fact visual ly non-empty yet.
2044 if (m_isVisuallyNonEmpty && !m_frame->document()->didLayoutWithPendingSt ylesheets() && m_firstVisuallyNonEmptyLayoutCallbackPending) { 2045 if (m_isVisuallyNonEmpty && !m_frame->document()->didLayoutWithPendingSt ylesheets() && m_firstVisuallyNonEmptyLayoutCallbackPending) {
2045 m_firstVisuallyNonEmptyLayoutCallbackPending = false; 2046 m_firstVisuallyNonEmptyLayoutCallbackPending = false;
2046 // FIXME: This callback is probably not needed, but is currently use d 2047 // FIXME: This callback is probably not needed, but is currently use d
2047 // by android for setting the background color. 2048 // by android for setting the background color.
2048 m_frame->loader().client()->dispatchDidFirstVisuallyNonEmptyLayout() ; 2049 m_frame->loader().client()->dispatchDidFirstVisuallyNonEmptyLayout() ;
2049 } 2050 }
2050 } 2051 }
2051 2052
2052 FontFaceSet::didLayout(m_frame->document()); 2053 FontFaceSet::didLayout(*m_frame->document());
2053 2054
2054 updateWidgetPositions(); 2055 updateWidgetPositions();
2055 2056
2056 // Plugins could have torn down the page inside updateWidgetPositions(). 2057 // Plugins could have torn down the page inside updateWidgetPositions().
2057 if (!renderView()) 2058 if (!renderView())
2058 return; 2059 return;
2059 2060
2060 if (!m_updateWidgetsTimer.isActive()) 2061 if (!m_updateWidgetsTimer.isActive())
2061 m_updateWidgetsTimer.startOneShot(0); 2062 m_updateWidgetsTimer.startOneShot(0);
2062 2063
(...skipping 1144 matching lines...) Expand 10 before | Expand all | Expand 10 after
3207 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 3208 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
3208 { 3209 {
3209 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 3210 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
3210 if (AXObjectCache* cache = axObjectCache()) { 3211 if (AXObjectCache* cache = axObjectCache()) {
3211 cache->remove(scrollbar); 3212 cache->remove(scrollbar);
3212 cache->handleScrollbarUpdate(this); 3213 cache->handleScrollbarUpdate(this);
3213 } 3214 }
3214 } 3215 }
3215 3216
3216 } // namespace WebCore 3217 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/frame/Frame.cpp ('k') | Source/core/frame/NavigatorID.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698