Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 165443002: No need to set __STDC_FORMAT_MACROS in config.h (Closed)

Created:
6 years, 10 months ago by lgombos
Modified:
6 years, 10 months ago
Reviewers:
eseidel
CC:
blink-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

__STDC_FORMAT_MACROS are already set for all chromium code, no need to set it again just for blink in config.h. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167158

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M Source/config.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lgombos
This is where it is set for all chromium code: https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&q=STDC_FORMAT_MACROS&sq=package:chromium&type=cs&l=2587 .
6 years, 10 months ago (2014-02-14 04:45:35 UTC) #1
eseidel
lgtm OK. Thakis is a great guy for build reviews, although I think he's OOO ...
6 years, 10 months ago (2014-02-14 04:47:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/165443002/1
6 years, 10 months ago (2014-02-14 04:47:46 UTC) #3
lgombos
On 2014/02/14 04:47:23, eseidel wrote: > Thakis is a great guy for build reviews, although ...
6 years, 10 months ago (2014-02-14 05:01:12 UTC) #4
eseidel
If thakis wants to post a patch to make himself owner of *.gyp on Blink, ...
6 years, 10 months ago (2014-02-14 05:42:56 UTC) #5
eseidel
I see, we're talking about config.h. Still he's probably just as good a reviewer for ...
6 years, 10 months ago (2014-02-14 05:44:01 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 06:49:13 UTC) #7
Message was sent while issue was closed.
Change committed as 167158

Powered by Google App Engine
This is Rietveld 408576698