Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 165434: Merge 22814 - Fix for an "update in progress" DCHECK.... (Closed)

Created:
11 years, 4 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
Paul Godavari
CC:
chromium-reviews_googlegroups.com, Paul Godavari, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 22814 - Fix for an "update in progress" DCHECK. A DCHECK in SafeBrowsingService::UpdateStarted can potentially be triggered if there is an error opening the database for reading, or if there is no response from the server for a update request. Both of these cases can cause our 'update_in_progress_' flag to not be reset properly before the next update. This CL adds: a timeout for update responses better handling for database errors that properly resets the update state. BUG=12835 (http://crbug.com/12835) TEST=None. Review URL: http://codereview.chromium.org/165008 TBR=paul@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
MM chrome/browser/safe_browsing/protocol_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
MM chrome/browser/safe_browsing/protocol_manager.cc View 4 chunks +28 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 4 months ago (2009-08-13 05:08:25 UTC) #1
Paul Godavari
11 years, 4 months ago (2009-08-13 05:27:37 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698