Issue 1654273003: Fix typedef cycle check (fixes #25620).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1654273003: Fix typedef cycle check (fixes #25620). (Closed)

Created:
4 years, 10 months ago by regis

Modified:
4 years, 10 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix typedef cycle check (fixes #25620). Add regression test. Fix BuildName for function types. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/48fc2338967782f26a72e3fb796665c10535294b

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -14 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	2 chunks	+12 lines, -6 lines	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+9 lines, -6 lines	0 comments	Download
A +	tests/language/regress_25620_test.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

regis

4 years, 10 months ago (2016-02-01 22:43:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
48fc2338967782f26a72e3fb796665c10535294b (presubmit successful).