Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Side by Side Diff: src/arm/assembler-arm-inl.h

Issue 1654263004: Call RecordWriteIntoCode when storing the target object in the reloc info on ARM and MIPS. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/assembler-arm64-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 void RelocInfo::set_target_object(Object* target, 131 void RelocInfo::set_target_object(Object* target,
132 WriteBarrierMode write_barrier_mode, 132 WriteBarrierMode write_barrier_mode,
133 ICacheFlushMode icache_flush_mode) { 133 ICacheFlushMode icache_flush_mode) {
134 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT); 134 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
135 Assembler::set_target_address_at(isolate_, pc_, host_, 135 Assembler::set_target_address_at(isolate_, pc_, host_,
136 reinterpret_cast<Address>(target), 136 reinterpret_cast<Address>(target),
137 icache_flush_mode); 137 icache_flush_mode);
138 if (write_barrier_mode == UPDATE_WRITE_BARRIER && 138 if (write_barrier_mode == UPDATE_WRITE_BARRIER &&
139 host() != NULL && 139 host() != NULL &&
140 target->IsHeapObject()) { 140 target->IsHeapObject()) {
141 host()->GetHeap()->incremental_marking()->RecordWrite( 141 host()->GetHeap()->incremental_marking()->RecordWriteIntoCode(
142 host(), &Memory::Object_at(pc_), HeapObject::cast(target)); 142 host(), this, HeapObject::cast(target));
143 } 143 }
144 } 144 }
145 145
146 146
147 Address RelocInfo::target_external_reference() { 147 Address RelocInfo::target_external_reference() {
148 DCHECK(rmode_ == EXTERNAL_REFERENCE); 148 DCHECK(rmode_ == EXTERNAL_REFERENCE);
149 return Assembler::target_address_at(pc_, host_); 149 return Assembler::target_address_at(pc_, host_);
150 } 150 }
151 151
152 152
(...skipping 467 matching lines...) Expand 10 before | Expand all | Expand 10 after
620 Assembler::FlushICache(isolate, pc, 4 * kInstrSize); 620 Assembler::FlushICache(isolate, pc, 4 * kInstrSize);
621 } 621 }
622 } 622 }
623 } 623 }
624 624
625 625
626 } // namespace internal 626 } // namespace internal
627 } // namespace v8 627 } // namespace v8
628 628
629 #endif // V8_ARM_ASSEMBLER_ARM_INL_H_ 629 #endif // V8_ARM_ASSEMBLER_ARM_INL_H_
OLDNEW
« no previous file with comments | « no previous file | src/arm64/assembler-arm64-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698