Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 165423002: Use validating IPC enum macros in common param traits. (Closed)

Created:
6 years, 10 months ago by Tom Sepez
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Use validating IPC enum macros in common param traits. This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M content/common/content_param_traits_macros.h View 1 chunk +10 lines, -5 lines 0 comments Download
M ui/events/latency_info.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
Tom Sepez
jbauman, please review. Note this is dependent on https://codereview.chromium.org/165213002/
6 years, 10 months ago (2014-02-13 23:52:02 UTC) #1
jbauman
lgtm
6 years, 10 months ago (2014-02-18 20:44:03 UTC) #2
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 10 months ago (2014-02-18 21:06:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/165423002/1
6 years, 10 months ago (2014-02-18 21:06:21 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 21:26:22 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=50773
6 years, 10 months ago (2014-02-18 21:26:23 UTC) #6
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 10 months ago (2014-02-18 21:56:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/165423002/1
6 years, 10 months ago (2014-02-18 21:56:32 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 21:56:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel, mac_chromium_rel
6 years, 10 months ago (2014-02-18 21:56:39 UTC) #10
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 10 months ago (2014-02-18 22:02:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/165423002/1
6 years, 10 months ago (2014-02-18 22:02:45 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 22:02:56 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel, mac_chromium_rel
6 years, 10 months ago (2014-02-18 22:02:56 UTC) #14
Tom Sepez
Jochen, can I get a quick owners stamp?
6 years, 10 months ago (2014-02-19 22:13:23 UTC) #15
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-20 08:06:46 UTC) #16
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 10 months ago (2014-02-20 18:20:41 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/165423002/1
6 years, 10 months ago (2014-02-20 18:21:34 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-20 21:23:46 UTC) #19
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=267189
6 years, 10 months ago (2014-02-20 21:23:47 UTC) #20
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 10 months ago (2014-02-22 00:14:29 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/165423002/1
6 years, 10 months ago (2014-02-22 00:15:37 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/165423002/1
6 years, 10 months ago (2014-02-22 01:31:46 UTC) #23
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 08:17:55 UTC) #24
Message was sent while issue was closed. 
Change committed as 252775

Powered by Google App Engine
This is Rietveld 408576698