Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1654223003: Revert "Removed support deprecated (//@|/*@) source(URL|MappingURL)=" (Closed)

Created:
4 years, 10 months ago by kozy
Modified:
4 years, 10 months ago
Reviewers:
Yang, adamk, Michael Hablich
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Removed support deprecated (//@|/*@) source(URL|MappingURL)=" A lot of deverlopers use deprecated sourceURL syntax. We should add console warning message before removing this. Original CL: https://codereview.chromium.org/1495633002/ BUG=chromium:558998 LOG=Y R=yangguo@chromium.org,hablich@chromium.org,adamk@chromium.org Committed: https://crrev.com/3c3d7e7be80f45eeea0dc74a71d7552e2afc2985 Cr-Commit-Position: refs/heads/master@{#33709}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -23 lines) Patch
M include/v8.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/js/messages.js View 1 chunk +4 lines, -3 lines 0 comments Download
M src/parsing/scanner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-conditional-position.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-109362.js View 1 2 chunks +10 lines, -10 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-481896.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-517592.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/stack-traces.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
kozy
Please take a look!
4 years, 10 months ago (2016-02-02 19:58:13 UTC) #1
Michael Hablich
On 2016/02/02 19:58:13, kozyatinskiy wrote: > Please take a look! What about the tests as ...
4 years, 10 months ago (2016-02-02 21:48:01 UTC) #3
Yang
On 2016/02/02 21:48:01, Hablich wrote: > On 2016/02/02 19:58:13, kozyatinskiy wrote: > > Please take ...
4 years, 10 months ago (2016-02-03 06:43:35 UTC) #4
kozy
I've reverted all tests.
4 years, 10 months ago (2016-02-03 08:09:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1654223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1654223003/20001
4 years, 10 months ago (2016-02-03 08:09:45 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10452)
4 years, 10 months ago (2016-02-03 08:12:10 UTC) #10
kozy
Adam, please take a look. I need owner lgtm for adamk@chromium.org
4 years, 10 months ago (2016-02-03 08:13:48 UTC) #13
adamk
lgtm for parsing/
4 years, 10 months ago (2016-02-03 18:41:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1654223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1654223003/20001
4 years, 10 months ago (2016-02-03 18:43:02 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-03 18:45:13 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 18:45:43 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c3d7e7be80f45eeea0dc74a71d7552e2afc2985
Cr-Commit-Position: refs/heads/master@{#33709}

Powered by Google App Engine
This is Rietveld 408576698