Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Unified Diff: chrome/browser/ui/views/toolbar/browser_actions_container.h

Issue 1654223002: Views - init less stuff in tabless browsers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/browser_actions_container.h
diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container.h b/chrome/browser/ui/views/toolbar/browser_actions_container.h
index b433a3fe3c14b2b00f6b2c62087a65fd6608ec5e..14517aae8b17d795ffd5e9a485662eb042f184e9 100644
--- a/chrome/browser/ui/views/toolbar/browser_actions_container.h
+++ b/chrome/browser/ui/views/toolbar/browser_actions_container.h
@@ -9,10 +9,8 @@
#include "base/macros.h"
#include "base/observer_list.h"
-#include "chrome/browser/extensions/extension_keybinding_registry.h"
#include "chrome/browser/ui/toolbar/toolbar_actions_bar.h"
#include "chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h"
-#include "chrome/browser/ui/views/extensions/extension_keybinding_registry_views.h"
#include "chrome/browser/ui/views/toolbar/chevron_menu_button.h"
#include "chrome/browser/ui/views/toolbar/toolbar_action_view.h"
#include "ui/gfx/animation/animation_delegate.h"
@@ -124,14 +122,12 @@ class ResizeArea;
// growing the container.
//
////////////////////////////////////////////////////////////////////////////////
-class BrowserActionsContainer
- : public views::View,
- public ToolbarActionsBarDelegate,
- public views::ResizeAreaDelegate,
- public gfx::AnimationDelegate,
- public ToolbarActionView::Delegate,
- public views::WidgetObserver,
- public extensions::ExtensionKeybindingRegistry::Delegate {
+class BrowserActionsContainer : public views::View,
+ public ToolbarActionsBarDelegate,
+ public views::ResizeAreaDelegate,
+ public gfx::AnimationDelegate,
+ public ToolbarActionView::Delegate,
+ public views::WidgetObserver {
public:
// Constructs a BrowserActionContainer for a particular |browser| object. For
// documentation of |main_container|, see class comments.
@@ -155,11 +151,6 @@ class BrowserActionsContainer
return toolbar_actions_bar_.get();
}
- // The class that registers for keyboard shortcuts for extension commands.
- extensions::ExtensionKeybindingRegistry* extension_keybinding_registry() {
- return extension_keybinding_registry_.get();
- }
-
// Get a particular toolbar action view.
ToolbarActionView* GetToolbarActionViewAt(int index) {
return toolbar_action_views_[index];
@@ -189,10 +180,6 @@ class BrowserActionsContainer
// animating to a new size, or (if not animating) the currently visible icons.
size_t VisibleBrowserActionsAfterAnimation() const;
- // Executes |command| registered by |extension|.
- void ExecuteExtensionCommand(const extensions::Extension* extension,
- const extensions::Command& command);
-
// Returns the preferred width given the limit of |max_width|. (Unlike most
// views, since we don't want to show part of an icon or a large space after
// the omnibox, this is probably *not* |max_width|).
@@ -260,10 +247,6 @@ class BrowserActionsContainer
void OnWidgetClosing(views::Widget* widget) override;
void OnWidgetDestroying(views::Widget* widget) override;
- // Overridden from extension::ExtensionKeybindingRegistry::Delegate:
- extensions::ActiveTabPermissionGranter* GetActiveTabPermissionGranter()
- override;
-
views::BubbleDelegateView* active_bubble() { return active_bubble_; }
ChevronMenuButton* chevron_for_testing() { return chevron_; }
@@ -348,9 +331,6 @@ class BrowserActionsContainer
// is none.
scoped_ptr<DropPosition> drop_position_;
- // The class that registers for keyboard shortcuts for extension commands.
- scoped_ptr<ExtensionKeybindingRegistryViews> extension_keybinding_registry_;
-
// The extension bubble that is actively showing, if any.
views::BubbleDelegateView* active_bubble_;
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/toolbar/browser_actions_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698