Issue 165421: Merge 21522 - Integrates a custom JumpList of Windows 7 into Chromium....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165421: Merge 21522 - Integrates a custom JumpList of Windows 7 into Chromium.... (Closed)

Created:
11 years, 4 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
Hironori Bono

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Description

Merge 21522 - Integrates a custom JumpList of Windows 7 into Chromium. This change adds an option "enablecustomjumplist" that uses the ICustomDestinationList interface to add "Most Visited" pages, "Recently Closed" pages, and "Tasks" to the JumpList of Chromium. This change registers the CustomJumpList class into an observer of TabRestoreService so it can update the JumpList when a user adds/removes a tab. This change stores icon files used by a custom JumpList under "$(User Data Dir)/JumpListIcons" so Taskbar can show JumpList icons even when Chromium is not running. BUG=8037 TEST=Rightclick the taskbar icon of Chromium on Windows 7. Review URL: http://codereview.chromium.org/56175 TBR=hbono@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23256

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, --2 lines)			Patch
A +	chrome/browser/jumplist.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/jumplist.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
MM	chrome/browser/views/frame/browser_view.h	View	3 chunks	+9 lines, -0 lines	0 comments	Download
MM	chrome/browser/views/frame/browser_view.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
MM	chrome/chrome.gyp	View	2 chunks	+3 lines, -0 lines	0 comments	Download
MM	chrome/common/chrome_constants.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
MM	chrome/common/chrome_constants.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
MM	chrome/common/chrome_switches.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
MM	chrome/common/chrome_switches.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.
Thank you for merging this change.

Expand Messages | Collapse Messages